[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 00/22] -Werror=maybe-uninitialized fixes
From: |
marcandre . lureau |
Subject: |
[PATCH v2 00/22] -Werror=maybe-uninitialized fixes |
Date: |
Tue, 24 Sep 2024 17:05:31 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Hi,
Depending on -Doptimization=<value>, GCC (14.2.1 here) produces different
maybe-uninitialized warnings:
- g: produces -Werror=maybe-uninitialized errors
- 0: clean build
- 1: produces -Werror=maybe-uninitialized errors
- 2: clean build
- 3: produces few -Werror=maybe-uninitialized errors
- s: produces -Werror=maybe-uninitialized errors
Most are false-positive, because prior LOCK_GUARD should guarantee an
initialization path. Few of them are a bit trickier. Finally, I found
a potential related memory leak.
thanks
v2:
- rebased, dropped some patches
- added some new patches with updated code-base and newer GCC
- added s-o-b/a-b
Marc-André Lureau (22):
util/coroutine: fix -Werror=maybe-uninitialized false-positive
util/timer: fix -Werror=maybe-uninitialized false-positive
hw/qxl: fix -Werror=maybe-uninitialized false-positives
nbd: fix -Werror=maybe-uninitialized false-positive
block/mirror: fix -Werror=maybe-uninitialized false-positive
block/mirror: fix -Werror=maybe-uninitialized false-positive
block/stream: fix -Werror=maybe-uninitialized false-positives
hw/ahci: fix -Werror=maybe-uninitialized false-positive
hw/vhost-scsi: fix -Werror=maybe-uninitialized
hw/sdhci: fix -Werror=maybe-uninitialized false-positive
block/block-copy: fix -Werror=maybe-uninitialized false-positive
migration: fix -Werror=maybe-uninitialized false-positives
hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive
migration: fix -Werror=maybe-uninitialized false-positive
linux-user/hppa: fix -Werror=maybe-uninitialized false-positive
target/loongarch: fix -Werror=maybe-uninitialized false-positive
tests: fix -Werror=maybe-uninitialized false-positive
hw/virtio: fix -Werror=maybe-uninitialized false-positive
block: fix -Werror=maybe-uninitialized false-positive
qom/object: fix -Werror=maybe-uninitialized
fsdep/9p: fix -Werror=maybe-uninitialized false-positive
RFC: hw/virtio: a potential leak fix
block/block-copy.c | 2 +-
block/file-posix.c | 2 +-
block/mirror.c | 8 ++++----
block/stream.c | 6 +++---
fsdev/9p-iov-marshal.c | 6 +++---
hw/block/virtio-blk.c | 2 +-
hw/display/qxl.c | 4 ++--
hw/ide/ahci.c | 3 ++-
hw/scsi/vhost-scsi.c | 2 +-
hw/sd/sdhci.c | 2 +-
hw/virtio/vhost-shadow-virtqueue.c | 6 ++++--
linux-user/hppa/cpu_loop.c | 10 +++++-----
migration/dirtyrate.c | 4 ++--
migration/migration.c | 2 +-
migration/ram.c | 2 +-
nbd/client-connection.c | 2 +-
qom/object.c | 5 ++++-
target/loongarch/gdbstub.c | 26 ++++++++++++++------------
tests/unit/test-bdrv-drain.c | 2 +-
tests/unit/test-block-iothread.c | 2 +-
util/qemu-coroutine.c | 2 +-
util/qemu-timer.c | 6 +++---
22 files changed, 57 insertions(+), 49 deletions(-)
--
2.45.2.827.g557ae147e6
- [PATCH v2 11/22] block/block-copy: fix -Werror=maybe-uninitialized false-positive, (continued)
- [PATCH v2 11/22] block/block-copy: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 12/22] migration: fix -Werror=maybe-uninitialized false-positives, marcandre . lureau, 2024/09/24
- [PATCH v2 01/22] util/coroutine: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 04/22] nbd: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 03/22] hw/qxl: fix -Werror=maybe-uninitialized false-positives, marcandre . lureau, 2024/09/24
- [PATCH v2 02/22] util/timer: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 05/22] block/mirror: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 06/22] block/mirror: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 07/22] block/stream: fix -Werror=maybe-uninitialized false-positives, marcandre . lureau, 2024/09/24
- [PATCH v2 08/22] hw/ahci: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 00/22] -Werror=maybe-uninitialized fixes,
marcandre . lureau <=
- [PATCH v2 01/22] util/coroutine: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 02/22] util/timer: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 03/22] hw/qxl: fix -Werror=maybe-uninitialized false-positives, marcandre . lureau, 2024/09/24
- [PATCH v2 04/22] nbd: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 06/22] block/mirror: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 05/22] block/mirror: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/09/24
- [PATCH v2 07/22] block/stream: fix -Werror=maybe-uninitialized false-positives, marcandre . lureau, 2024/09/24