qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 3/6] migration/multifd: Fix loop conditions in multifd_zstd_se


From: Peter Xu
Subject: Re: [PULL 3/6] migration/multifd: Fix loop conditions in multifd_zstd_send_prepare and multifd_zstd_recv
Date: Wed, 18 Sep 2024 09:17:50 -0400

On Wed, Sep 18, 2024 at 07:47:42AM +0200, Stefan Weil wrote:
> Am 17.09.24 um 23:55 schrieb Peter Xu:
> 
> > From: Stefan Weil via <qemu-devel@nongnu.org>
> 
> 
> How can I avoid that my author name/email is changed so often?
> 
> Will this be fixed automatically before the commit is merged?

Hmm, this is pretty weird, as I actually did see this checkpatch error,
then I should have manually fixed the --author of your commit after queued,
as it was indeed mangled in the original patch:

20240910054138.1458555-1-sw@weilnetz.de/">https://lore.kernel.org/all/20240910054138.1458555-1-sw@weilnetz.de/

However it doesn't seem like working.. I checked again, that checkpatch
uses --no-mailmap so it still shows the mangled email.. I fixed it again
locally, then the error is gone.

Sorry, I don't know what happened, and why I used to fix it the same way
(that is, "git commit --author "XXX" --amend) but it didn't work last time
(but I guess .mailmap made it harder for me to recognize..).

It seems that we already have this:

commit 5204b499a6cae4dfd9fe762d5e6e82224892383b
Author: Philippe Mathieu-Daudé <philmd@linaro.org>
Date:   Thu Dec 8 16:55:35 2022 +0100

    mailmap: Fix Stefan Weil author email
 
So I assume even if Peter applies this PR it'll still show correct.

However if you (or Peter, any of you) prefer me to resend a pull, I can do
that too.  Let me know.

Thanks,

-- 
Peter Xu




reply via email to

[Prev in Thread] Current Thread [Next in Thread]