Re: [PATCH v6 5/8] device/virtio-nsm: Support for Nitro Secure Module device

[Michael S. Tsirkin]

On Mon, Sep 16, 2024 at 01:46:52AM +0600, Dorjoy Chowdhury wrote:
>     > +    len = cbor_serialize(root, response->iov_base, response->iov_len);
> 
>     As far as I can tell, all these also need to be switched to use
>     iov_from_buf.
> 
> 
> Sorry I didn't understand this. The iovecs passed in these functions are not
> the iovecs from virtqueue. We make an iovec for the response and then pass it
> down. We do the "iov_from_buf" after calling "get_nsm_request_response" in
> "handle_input" function. Am I missing something?
> 
> Regards,
> Dorjoy


Oh, I misunderstood. Passing in a pointer and length might be clearer.
Not critical.

-- 
MST