[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/17] kvm/i386: make kvm_filter_msr() and related definitions pri
From: |
Paolo Bonzini |
Subject: |
[PULL 06/17] kvm/i386: make kvm_filter_msr() and related definitions private to kvm module |
Date: |
Wed, 11 Sep 2024 14:33:31 +0200 |
From: Ani Sinha <anisinha@redhat.com>
kvm_filer_msr() is only used from i386 kvm module. Make it static so that its
easy for developers to understand that its not used anywhere else.
Same for QEMURDMSRHandler, QEMUWRMSRHandler and KVMMSRHandlers definitions.
CC: philmd@linaro.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Ani Sinha <anisinha@redhat.com>
Link: 20240903140045.41167-1-anisinha@redhat.com">https://lore.kernel.org/r/20240903140045.41167-1-anisinha@redhat.com
[Make struct unnamed. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/kvm/kvm_i386.h | 11 -----------
target/i386/kvm/kvm.c | 12 +++++++++++-
2 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/target/i386/kvm/kvm_i386.h b/target/i386/kvm/kvm_i386.h
index 34fc60774b8..9de9c0d3038 100644
--- a/target/i386/kvm/kvm_i386.h
+++ b/target/i386/kvm/kvm_i386.h
@@ -66,17 +66,6 @@ uint64_t kvm_swizzle_msi_ext_dest_id(uint64_t address);
void kvm_update_msi_routes_all(void *private, bool global,
uint32_t index, uint32_t mask);
-typedef bool QEMURDMSRHandler(X86CPU *cpu, uint32_t msr, uint64_t *val);
-typedef bool QEMUWRMSRHandler(X86CPU *cpu, uint32_t msr, uint64_t val);
-typedef struct kvm_msr_handlers {
- uint32_t msr;
- QEMURDMSRHandler *rdmsr;
- QEMUWRMSRHandler *wrmsr;
-} KVMMSRHandlers;
-
-bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
- QEMUWRMSRHandler *wrmsr);
-
#endif /* CONFIG_KVM */
void kvm_pc_setup_irq_routing(bool pci_enabled);
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 381f414d1e0..d95013a2ce6 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -92,7 +92,17 @@
* 255 kvm_msr_entry structs */
#define MSR_BUF_SIZE 4096
+typedef bool QEMURDMSRHandler(X86CPU *cpu, uint32_t msr, uint64_t *val);
+typedef bool QEMUWRMSRHandler(X86CPU *cpu, uint32_t msr, uint64_t val);
+typedef struct {
+ uint32_t msr;
+ QEMURDMSRHandler *rdmsr;
+ QEMUWRMSRHandler *wrmsr;
+} KVMMSRHandlers;
+
static void kvm_init_msrs(X86CPU *cpu);
+static bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
+ QEMUWRMSRHandler *wrmsr);
const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
KVM_CAP_INFO(SET_TSS_ADDR),
@@ -5735,7 +5745,7 @@ static bool kvm_install_msr_filters(KVMState *s)
return true;
}
-bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
+static bool kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,
QEMUWRMSRHandler *wrmsr)
{
int i;
--
2.46.0
- [PULL 00/17] Misc patches for 2024-09-11, Paolo Bonzini, 2024/09/11
- [PULL 01/17] target/i386: Delete duplicated macro definition CR4_FRED_MASK, Paolo Bonzini, 2024/09/11
- [PULL 03/17] target/i386: Raise the highest index value used for any VMCS encoding, Paolo Bonzini, 2024/09/11
- [PULL 02/17] target/i386: Add VMX control bits for nested FRED support, Paolo Bonzini, 2024/09/11
- [PULL 04/17] tests/unit: remove block layer code from test-nested-aio-poll, Paolo Bonzini, 2024/09/11
- [PULL 05/17] hw/i386/pc: Add a description for the i8042 property, Paolo Bonzini, 2024/09/11
- [PULL 06/17] kvm/i386: make kvm_filter_msr() and related definitions private to kvm module,
Paolo Bonzini <=
- [PULL 07/17] kvm/i386: fix return values of is_host_cpu_intel(), Paolo Bonzini, 2024/09/11
- [PULL 08/17] kvm: replace fprintf with error_report()/printf() in kvm_init(), Paolo Bonzini, 2024/09/11
- [PULL 09/17] kvm/i386: refactor kvm_arch_init and split it into smaller functions, Paolo Bonzini, 2024/09/11
- [PULL 10/17] kvm/i386: replace identity_base variable with a constant, Paolo Bonzini, 2024/09/11
- [PULL 12/17] target/i386: Expose IBPB-BRTYPE and SBPB CPUID bits to the guest, Paolo Bonzini, 2024/09/11
- [PULL 13/17] hw: Remove unused inclusion of hw/char/serial.h, Paolo Bonzini, 2024/09/11
- [PULL 14/17] hw/char/serial.h: Extract serial-isa.h, Paolo Bonzini, 2024/09/11
- [PULL 17/17] minikconf: print error entirely on stderr, Paolo Bonzini, 2024/09/11
- [PULL 11/17] kvm: refactor core virtual machine creation into its own function, Paolo Bonzini, 2024/09/11
- [PULL 15/17] hw/char: Extract serial-mm, Paolo Bonzini, 2024/09/11