qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled
Date: Wed, 11 Sep 2024 14:10:36 +0200
User-agent: Mozilla Thunderbird

On 11/9/24 11:14, gert.wollny@collabora.com wrote:
From: Gert Wollny <gert.wollny@collabora.com>

Before 176e3783f2ab (ui/sdl2: OpenGL window context)
SDL_CreateRenderer was called unconditionally setting
the swap interval to 0. Since SDL_CreateRenderer is now no
longer called when OpenGL is enabled, the swap interval is
no longer set explicitly and vsync handling depends on
the environment settings which may lead to a performance
regression with virgl as reported in
    https://gitlab.com/qemu-project/qemu/-/issues/2565

Restore the old vsync handling by explicitly calling
SDL_GL_SetSwapInterval if OpenGL is enabled.

Fixes: 176e3783f2ab (ui/sdl2: OpenGL window context)
Closes: https://gitlab.com/qemu-project/qemu/-/issues/2565

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
---
  ui/sdl2.c | 1 +
  1 file changed, 1 insertion(+)

Queued, thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]