[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] Postcopy migration and vhost-user errors
From: |
Prasad Pandit |
Subject: |
Re: [PATCH v2 0/2] Postcopy migration and vhost-user errors |
Date: |
Wed, 11 Sep 2024 12:44:59 +0530 |
Hello Michael,
On Tue, 10 Sept 2024 at 22:40, Michael S. Tsirkin <mst@redhat.com> wrote:
> So are we going to see a version with BQL?
===
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index cdf9af4a4b..96ac0ed93b 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -2079,6 +2079,7 @@ static int vhost_user_postcopy_end(struct
vhost_dev *dev, Error **errp)
trace_vhost_user_postcopy_end_entry();
+ BQL_LOCK_GUARD();
ret = vhost_user_write(dev, &msg, NULL, 0);
if (ret < 0) {
error_setg(errp, "Failed to send postcopy_end to vhost");
--
2.43.5
===
* We ran the test with the above BQL patch, but it did not help to fix
race errors. I'm continuing to debug it, will update here soon.
Thank you.
---
- Prasad