Re: [PATCH for-9.2 v15 00/11] hw/pci: SR-IOV related fixes and improvements

[Akihiko Odaki]

On 2024/09/10 18:21, Michael S. Tsirkin wrote:
> On Fri, Aug 23, 2024 at 02:00:37PM +0900, Akihiko Odaki wrote:
> > Supersedes: <20240714-rombar-v2-0-af1504ef55de@daynix.com>
> > ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto")
> >
> > I submitted a RFC series[1] to add support for SR-IOV emulation to
> > virtio-net-pci. During the development of the series, I fixed some
> > trivial bugs and made improvements that I think are independently
> > useful. This series extracts those fixes and improvements from the RFC
> > series.
> >
> > [1]: https://patchew.org/QEMU/20231210-sriov-v2-0-b959e8a6dfaf@daynix.com/
> >
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> I don't think Cédric's issues have been addressed, am I wrong?
> Cédric, what is your take?
I put the URI to Cédric's report here:
https://lore.kernel.org/r/75cbc7d9-b48e-4235-85cf-49dacf3c7483@redhat.com

This issue was dealt with patch "s390x/pci: Check for multifunction 
after device realization". I found that s390x on QEMU does not support 
multifunction and SR-IOV devices accidentally circumvent this 
restriction, which means igb was never supposed to work with s390x. The 
patch prevents adding SR-IOV devices to s390x to ensure the restriction 
is properly enforced.
Regards,
Akihiko Odaki