[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 2/5] gdbstub: Add support for MTE in system mode
From: |
Gustavo Romero |
Subject: |
[PATCH v4 2/5] gdbstub: Add support for MTE in system mode |
Date: |
Fri, 6 Sep 2024 14:33:13 +0000 |
This commit makes handle_q_memtag, handle_q_isaddresstagged, and
handle_Q_memtag stubs build for system mode, allowing all GDB
'memory-tag' subcommands to work with QEMU gdbstub on aarch64 system
mode.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/620
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/gdbstub64.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c
index 85a19c14c7..9462d3f560 100644
--- a/target/arm/gdbstub64.c
+++ b/target/arm/gdbstub64.c
@@ -430,6 +430,7 @@ int aarch64_gdb_set_tag_ctl_reg(CPUState *cs, uint8_t *buf,
int reg)
return 0;
#endif
}
+#endif /* CONFIG_USER_ONLY */
static void handle_q_memtag(GArray *params, void *user_ctx)
{
@@ -600,12 +601,10 @@ static const GdbCmdParseEntry cmd_handler_table[NUM_CMDS]
= {
.need_cpu_context = true
},
};
-#endif /* CONFIG_USER_ONLY */
void aarch64_cpu_register_gdb_commands(ARMCPU *cpu, GString *qsupported,
GPtrArray *qtable, GPtrArray *stable)
{
-#ifdef CONFIG_USER_ONLY
/* MTE */
if (cpu_isar_feature(aa64_mte, cpu)) {
g_string_append(qsupported, ";memory-tagging+");
@@ -614,5 +613,4 @@ void aarch64_cpu_register_gdb_commands(ARMCPU *cpu, GString
*qsupported,
g_ptr_array_add(qtable, (gpointer)
&cmd_handler_table[qIsAddressTagged]);
g_ptr_array_add(stable, (gpointer) &cmd_handler_table[QMemTags]);
}
-#endif
}
--
2.34.1
- [PATCH v4 0/5] gdbstub: Add support for MTE in system mode, Gustavo Romero, 2024/09/06
- [PATCH v4 1/5] gdbstub: Use specific MMU index when probing MTE addresses, Gustavo Romero, 2024/09/06
- [PATCH v4 2/5] gdbstub: Add support for MTE in system mode,
Gustavo Romero <=
- [PATCH v4 3/5] tests/guest-debug: Support passing arguments to the GDB test script, Gustavo Romero, 2024/09/06
- [PATCH v4 4/5] tests/tcg/aarch64: Improve linker script organization, Gustavo Romero, 2024/09/06
- [PATCH v4 5/5] tests/tcg/aarch64: Extend MTE gdbstub tests to system mode, Gustavo Romero, 2024/09/06
- Re: [PATCH v4 0/5] gdbstub: Add support for MTE in system mode, Alex Bennée, 2024/09/10