Re: [PATCH 1/5] target/loongarch: Add a new cpu_type la664

[gaosong]

在 2024/9/5 下午6:32, Philippe Mathieu-Daudé 写道:
> Hi,
>
> On 29/7/24 03:39, Song Gao wrote:
> > Add a new LoongArch cpu type la664. The la664 has many new features,
> > such as new atomic instructions, hardware page table walk, etc.
> > We will implement them later.
> >
> > Signed-off-by: Song Gao <gaosong@loongson.cn>
> > ---
> >   target/loongarch/cpu.c | 48 +++++++++++++++++++++++++++++++-----------
> >   1 file changed, 36 insertions(+), 12 deletions(-)
>
>
> > +static void loongarch_la664_initfn(Object *obj)
> > +{
> > +    LoongArchCPU *cpu = LOONGARCH_CPU(obj);
> > +    CPULoongArchState *env = &cpu->env;
> > +    int i;
> > +
> > +    for (i = 0; i < 21; i++) {
>
> In order to remove the '21' magic value, can we use:
>
>       for (unsigned i = 0; i < ARRAY_SIZE(env->cpucfg); i++) {
Thank you,   I will correct it on v2.

Thanks.
Song Gao
> > +        env->cpucfg[i] = 0x0;
> > +    }
> > +
> > +    cpu->dtb_compatible = "loongarch,Loongson-3A6000";
> > +    env->cpucfg[0] = 0x14d000; /* PRID */
> > +
> > +    loongarch_common_initfn(env, obj);
> > +}
> > +
> > +static void loongarch_la464_initfn(Object *obj)
> > +{
> > +    LoongArchCPU *cpu = LOONGARCH_CPU(obj);
> > +    CPULoongArchState *env = &cpu->env;
> > +    int i;
> > +
> > +    for (i = 0; i < 21; i++) {
>
> Ditto.
>
> > +        env->cpucfg[i] = 0x0;
> > +    }
> > +
> > +    cpu->dtb_compatible = "loongarch,Loongson-3A5000";
> > +    env->cpucfg[0] = 0x14c010;  /* PRID */
> > +
> > +    loongarch_common_initfn(env, obj);
> > +}