Re: [PATCH] qapi: Document QCryptodevBackendServiceType

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 12/8/24 03:42, zhenwei pi wrote:
>> QCryptodevBackendServiceType was introduced by
>> bc304a6442e (cryptodev: Introduce server type in QAPI). However there
>> is a lack of member description. Thanks to Markus for pointing out
>> this.
>> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
>> ---
>>   qapi/cryptodev.json | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>> diff --git a/qapi/cryptodev.json b/qapi/cryptodev.json
>> index 68289f4984..9622c6d92b 100644
>> --- a/qapi/cryptodev.json
>> +++ b/qapi/cryptodev.json
>> @@ -28,6 +28,16 @@
>>   #
>>   # The supported service types of a crypto device.
>>   #
>> +# @cipher: Symmetric Key Cipher service
>> +#
>> +# @hash: Hash service
>> +#
>> +# @mac: Message Authentication Codes service
>> +#
>> +# @aead: Authenticated Encryption with Associated Data service
>> +#
>> +# @akcipher: Asymmetric Key Cipher service
>
> Can we drop all trailing "service"s?

No opinion myself.  Eric, what do you think?

>> +#
>>   # Since: 8.0
>>   ##
>>   { 'enum': 'QCryptodevBackendServiceType',