Re: [PATCH] target/arm: Correct names of VFP VFNMA and VFNMS insns

[Richard Henderson]

On 9/2/24 06:21, Peter Maydell wrote:
> On Fri, 30 Aug 2024 at 16:21, Peter Maydell <peter.maydell@linaro.org> wrote:
> > In vfp.decode we have the names of the VFNMA and VFNMS instructions
> > the wrong way around.  The architecture says that bit 6 is the 'op'
> > bit, which is 1 for VFNMA and 1 for VFNMS, but we label these two
>
> Doh. "1 for VFNMA and 0 for VFNMS"...
>
> > lines of decode the other way around.  This doesn't cause any
> > user-visible problem because in the handling of these functions in
> > translate-vfp.c we give VFNMA the behaviour specified for VFNMS and
> > vice-versa, but it's confusing when reading the code.
>
> -- PMM

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~