[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/7] hw/net/can/xlnx-versal-canfd: Handle flags correctly
From: |
Pavel Pisa |
Subject: |
Re: [PATCH v2 4/7] hw/net/can/xlnx-versal-canfd: Handle flags correctly |
Date: |
Thu, 29 Aug 2024 15:13:34 +0200 |
User-agent: |
KMail/1.9.10 |
On Tuesday 27 of August 2024 05:49:24 Doug Brown wrote:
> Add support for QEMU_CAN_FRMF_ESI and QEMU_CAN_FRMF_BRS flags, and
> ensure frame->flags is always initialized to 0.
>
> Note that the Xilinx IP core doesn't allow manually setting the ESI bit
> during transmits, so it's only implemented for the receive case.
>
> Signed-off-by: Doug Brown <doug@schmorgal.com>
Reviewed-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
--
Pavel Pisa
phone: +420 603531357
e-mail: pisa@cmp.felk.cvut.cz
Department of Control Engineering FEE CVUT
Karlovo namesti 13, 121 35, Prague 2
university: http://control.fel.cvut.cz/
personal: http://cmp.felk.cvut.cz/~pisa
social: https://social.kernel.org/ppisa
projects: https://www.openhub.net/accounts/ppisa
CAN related:http://canbus.pages.fel.cvut.cz/
RISC-V education: https://comparch.edu.cvut.cz/
Open Technologies Research Education and Exchange Services
https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home
- [PATCH v2 0/7] hw/net/can/xlnx-versal-canfd: Miscellaneous fixes, Doug Brown, 2024/08/26
- [PATCH v2 1/7] hw/net/can/xlnx-versal-canfd: Fix interrupt level, Doug Brown, 2024/08/26
- [PATCH v2 2/7] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check, Doug Brown, 2024/08/26
- [PATCH v2 3/7] hw/net/can/xlnx-versal-canfd: Translate CAN ID registers, Doug Brown, 2024/08/26
- [PATCH v2 4/7] hw/net/can/xlnx-versal-canfd: Handle flags correctly, Doug Brown, 2024/08/26
- Re: [PATCH v2 4/7] hw/net/can/xlnx-versal-canfd: Handle flags correctly,
Pavel Pisa <=
- [PATCH v2 7/7] hw/net/can/xlnx-versal-canfd: Fix FIFO issues, Doug Brown, 2024/08/26
- [PATCH v2 5/7] hw/net/can/xlnx-versal-canfd: Fix byte ordering, Doug Brown, 2024/08/26
- [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions, Doug Brown, 2024/08/26