Re: [PATCH v6 13/16] target/riscv: implement zicfiss instructions

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 13/16] target/riscv: implement zicfiss instructions

From:	Deepak Gupta
Subject:	Re: [PATCH v6 13/16] target/riscv: implement zicfiss instructions
Date:	Wed, 21 Aug 2024 18:00:04 -0700

On Thu, Aug 22, 2024 at 10:57:10AM +1000, Richard Henderson wrote:

On 8/22/24 07:50, Deepak Gupta wrote:

--- a/target/riscv/insn_trans/trans_rva.c.inc
+++ b/target/riscv/insn_trans/trans_rva.c.inc
@@ -18,6 +18,8 @@
  * this program.  If not, see <http://www.gnu.org/licenses/>.
  */
+#include "exec/memop.h"
+

Why? This will have been done long ago, within the includes oftranslate.c, the parent of this file.


Leftover from early versions. Thought I removed it.
Will fix it.

+static bool trans_ssrdp(DisasContext *ctx, arg_ssrdp *a)
+{
+    if (!ctx->bcfi_enabled || a->rd == 0) {
+        return false;
+    }
+
+    TCGv dest = tcg_temp_new();


dest = dest_gpr(ctx, a->rd);

Ok.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v6 09/16] target/riscv: introduce ssp and enabling controls for zicfiss, (continued)
- [PATCH v6 10/16] target/riscv: tb flag for shadow stack instructions, Deepak Gupta, 2024/08/21
- [PATCH v6 11/16] target/riscv: mmu changes for zicfiss shadow stack protection, Deepak Gupta, 2024/08/21
  - Re: [PATCH v6 11/16] target/riscv: mmu changes for zicfiss shadow stack protection, Richard Henderson, 2024/08/21
- [PATCH v6 12/16] target/riscv: AMO operations always raise store/AMO fault, Deepak Gupta, 2024/08/21
  - Re: [PATCH v6 12/16] target/riscv: AMO operations always raise store/AMO fault, Richard Henderson, 2024/08/21
    - Re: [PATCH v6 12/16] target/riscv: AMO operations always raise store/AMO fault, Deepak Gupta, 2024/08/21
    - Re: [PATCH v6 12/16] target/riscv: AMO operations always raise store/AMO fault, Richard Henderson, 2024/08/22
- [PATCH v6 13/16] target/riscv: implement zicfiss instructions, Deepak Gupta, 2024/08/21
  - Re: [PATCH v6 13/16] target/riscv: implement zicfiss instructions, Richard Henderson, 2024/08/21
    - Re: [PATCH v6 13/16] target/riscv: implement zicfiss instructions, Deepak Gupta <=
- [PATCH v6 14/16] target/riscv: compressed encodings for sspush and sspopchk, Deepak Gupta, 2024/08/21
- [PATCH v6 15/16] disas/riscv: enable disassembly for zicfiss instructions, Deepak Gupta, 2024/08/21
- [PATCH v6 16/16] disas/riscv: enable disassembly for compressed sspush/sspopchk, Deepak Gupta, 2024/08/21

Prev by Date: Re: [PATCH v6 12/16] target/riscv: AMO operations always raise store/AMO fault
Next by Date: Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check
Previous by thread: Re: [PATCH v6 13/16] target/riscv: implement zicfiss instructions
Next by thread: [PATCH v6 14/16] target/riscv: compressed encodings for sspush and sspopchk
Index(es):
- Date
- Thread