qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 3/5] tests/avocado: apply proper skipUnless decorator


From: Philippe Mathieu-Daudé
Subject: Re: [PULL 3/5] tests/avocado: apply proper skipUnless decorator
Date: Tue, 20 Aug 2024 00:31:33 +0200
User-agent: Mozilla Thunderbird

On 16/8/24 09:22, Thomas Huth wrote:
From: Cleber Rosa <crosa@redhat.com>

Commit 9b45cc993 added many cases of skipUnless for the sake of
organizing flaky tests.  But, Python decorators *must* follow what
they decorate, so the newlines added should *not* exist there.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Message-ID: <20240806173119.582857-3-crosa@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  tests/avocado/boot_linux_console.py | 1 -
  tests/avocado/intel_iommu.py        | 1 -
  tests/avocado/linux_initrd.py       | 1 -
  tests/avocado/machine_aspeed.py     | 2 --
  tests/avocado/machine_mips_malta.py | 2 --
  tests/avocado/machine_rx_gdbsim.py  | 1 -
  tests/avocado/reverse_debugging.py  | 4 ----
  tests/avocado/smmu.py               | 1 -
  8 files changed, 13 deletions(-)


diff --git a/tests/avocado/machine_rx_gdbsim.py 
b/tests/avocado/machine_rx_gdbsim.py
index 412a7a5089..9a0bec8a6e 100644
--- a/tests/avocado/machine_rx_gdbsim.py
+++ b/tests/avocado/machine_rx_gdbsim.py
@@ -49,7 +49,6 @@ def test_uboot(self):
          #exec_command_and_wait_for_pattern(self, 'version', gcc_version)
@skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable on GitLab')
-
      def test_linux_sash(self):
          """
          Boots a Linux kernel and checks that the console is operational.

For some weird reason a part of this patch is missing...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]