Re: [PATCH-for-9.1 v3 0/2] hw/i386/pc: Fix vmport option handling

[Bernhard Beschow]

Am 17. August 2024 15:24:31 UTC schrieb "Kamil Szczęk" <kamil@szczek.dev>:
>Some time ago a new option to disable the built-in i8042 controller was
>introduced (commit 4ccd5fe22feb95137d325f422016a6473541fe9f). This
>however introduced a side-effect - disabling this controller resulted
>in vmport's creation being omitted, regardless if it was enabled
>implicitly or explicitly. This patch series aims to clean up vmport
>option handling and introduces additional validation for these options.
>
>Changelog:
>
>v2 -> v3:
>  - Move vmport=auto -> vmport=on/off conversion to a shared code path
>  - Reword documentation for the vmport option, "and/or" => "or"

The vmport handling is now confined to pc.c. Excellent!

Series:
Reviewed-by: Bernhard Beschow <shentey@gmail.com>

>
>v1 -> v2:
>  - Exit with a useful error message instead of issuing a warning
>
>Kamil Szczęk (2):
>  hw/i386/pc: Unify vmport=auto handling
>  hw/i386/pc: Ensure vmport prerequisites are fulfilled
>
> hw/i386/pc.c      | 14 ++++++++++++--
> hw/i386/pc_piix.c |  5 -----
> hw/i386/pc_q35.c  |  5 -----
> qemu-options.hx   |  4 ++--
> 4 files changed, 14 insertions(+), 14 deletions(-)
>