Re: [PATCH v6 00/10] Add ACPI CPER firmware first error injection on ARM emulation

[Mauro Carvalho Chehab]

Em Mon, 12 Aug 2024 14:18:35 +0200
Igor Mammedov <imammedo@redhat.com> escreveu:

> On Thu, 8 Aug 2024 14:57:35 +0200
> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
> 
> > Em Thu,  8 Aug 2024 14:26:26 +0200
> > Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:
> >   
> > > v6:
> > > - PNP0C33 device creation moved to aml-build.c;
> > > - acpi_ghes record functions now use ACPI notify parameter,
> > >   instead of source ID;
> > > - the number of source IDs is now automatically calculated;
> > > - some code cleanups and function/var renames;
> > > - some fixes and cleanups at the error injection script;
> > > - ghes cper stub now produces an error if cper JSON is not compiled;
> > > - Offset calculation logic for GHES was refactored;
> > > - Updated documentation to reflect the GHES allocated size;
> > > - Added a x-mpidr object for QOM usage;
> > > - Added a patch making usage of x-mpidr field at ARM injection
> > >   script;  
> 
> stopping review at 5/10 and expecting a version with
> GHES source to error status block mapping fetched from
> HEST in guest RAM, instead of pre-calculated offsets
> in source code  (as in this series) to avoid migration
> issues and keeping compat plumbing manageable down the road.

Done. Sent a version 7 addressing it, and the other received
feedbacks. On this version, there are just two offsets used
during error injection:

1) the ack offset: represented relative to HEST table;
2) the CPER data offset: relative to /etc/hardware_errors table.

Thanks,
Mauro