Re: [PATCH] hw/misc/stm32l4x5_rcc: Add validation for MCOPRE and MCOSEL values

[Peter Maydell]

On Fri, 21 Jun 2024 at 13:59, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 18 Jun 2024 at 14:56, Zheyu Ma <zheyuma97@gmail.com> wrote:
> >
> > This commit adds validation checks for the MCOPRE and MCOSEL values in
> > the rcc_update_cfgr_register function. If the MCOPRE value exceeds
> > 0b100 or the MCOSEL value exceeds 0b111, an error is logged and the
> > corresponding clock mux is disabled. This helps in identifying and
> > handling invalid configurations in the RCC registers.
> >
> > Reproducer:
> > cat << EOF | qemu-system-aarch64 -display \
> > none -machine accel=qtest, -m 512M -machine b-l475e-iot01a -qtest \
> > stdio
> > writeq 0x40021008 0xffffffff
> > EOF
> >
> > Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> > ---
> >  hw/misc/stm32l4x5_rcc.c | 28 ++++++++++++++++++++--------
> >  1 file changed, 20 insertions(+), 8 deletions(-)
>
>
> Applied to target-arm.next, thanks. (I added a line
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2356
> to the commit message.)

I've just noticed that although I said I'd applied this
patch it somehow got lost and never made it upstream.
I have applied it to target-arm.next for real this time.
(This is the second patch around this timeframe that I
discovered I'd somehow accidentally dropped, so I just
did a check through all the patches I claimed to have
applied to target-arm.next in the last three months
to see if any others slipped through the net, but it
looks like there weren't any others.)

thanks, and apologies for the delay
-- PMM