[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] i386/cpu: Introduce enable_cpuid_0x1f to force exposing CPUI
|
From: |
Zhao Liu |
|
Subject: |
Re: [PATCH] i386/cpu: Introduce enable_cpuid_0x1f to force exposing CPUID 0x1f |
|
Date: |
Tue, 13 Aug 2024 15:36:14 +0800 |
On Tue, Aug 13, 2024 at 10:52:27AM +0800, Xiaoyao Li wrote:
[snip]
> > Any levels that 0xb doesn't cover.
>
> The name of extended_topo is so misleading. At least, it misleads me.
>
> Both Intel and AMD support leaf 0xb and the name of leaf 0xb is "Extended
> topology enumeration". And here, x86_has_extended_topo() is used for topo
> levels that cannot be covered by 0xb.
>
Yes, names are really hard, Intel and AMD have different naming for
topology leafs (the ones 0xb doesn't cover)... This helper has a
comment, which is also a clear expression of what it is doing.
Thanks,
Zhao