[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 10/10] savevm: Fix load_snapshot error path crash
From: |
Nicholas Piggin |
Subject: |
[PATCH v6 10/10] savevm: Fix load_snapshot error path crash |
Date: |
Tue, 13 Aug 2024 15:06:37 +1000 |
An error path missed setting *errp, which can cause a NULL deref.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
migration/savevm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/savevm.c b/migration/savevm.c
index 85958d7b09..6bb404b9c8 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -3288,6 +3288,7 @@ bool load_snapshot(const char *name, const char *vmstate,
/* Don't even try to load empty VM states */
ret = bdrv_snapshot_find(bs_vm_state, &sn, name);
if (ret < 0) {
+ error_setg(errp, "Snapshot can not be found");
return false;
} else if (sn.vm_state_size == 0) {
error_setg(errp, "This is a disk-only snapshot. Revert to it "
--
2.45.2
- [PATCH v6 00/10] replay: fixes and new test cases, Nicholas Piggin, 2024/08/13
- [PATCH v6 01/10] scripts/replay-dump.py: Update to current rr record format, Nicholas Piggin, 2024/08/13
- [PATCH v6 02/10] scripts/replay-dump.py: rejig decoders in event number order, Nicholas Piggin, 2024/08/13
- [PATCH v6 03/10] tests/avocado: excercise scripts/replay-dump.py in replay tests, Nicholas Piggin, 2024/08/13
- [PATCH v6 04/10] replay: allow runstate shutdown->running when replaying trace, Nicholas Piggin, 2024/08/13
- [PATCH v6 05/10] Revert "replay: stop us hanging in rr_wait_io_event", Nicholas Piggin, 2024/08/13
- [PATCH v6 06/10] tests/avocado: replay_kernel.py add x86-64 q35 machine test, Nicholas Piggin, 2024/08/13
- [PATCH v6 07/10] chardev: set record/replay on the base device of a muxed device, Nicholas Piggin, 2024/08/13
- [PATCH v6 08/10] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state, Nicholas Piggin, 2024/08/13
- [PATCH v6 09/10] virtio-net: Use virtual time for RSC timers, Nicholas Piggin, 2024/08/13
- [PATCH v6 10/10] savevm: Fix load_snapshot error path crash,
Nicholas Piggin <=
- Re: [PATCH v6 00/10] replay: fixes and new test cases, Alex Bennée, 2024/08/13