qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v3 00/12] hw/misc/aspeed_hace: Fix SG Accumulative Hash Calcu


From: Alejandro Zeise
Subject: RE: [PATCH v3 00/12] hw/misc/aspeed_hace: Fix SG Accumulative Hash Calculations
Date: Tue, 6 Aug 2024 18:51:42 +0000

> To allow 'make check' to succeed at every individual patch, you'll need to 
> re-order these, and split a couple of patches, to be more or less like this:
>
>  crypto: accumulative hashing API   (only define new driver APIs & new public 
> APIs here)
>  crypto/hash-glib: Implement new hash API
>   crypto/hash-gcrypt: Implement new hash API
>  crypto/hash-gnutls: Implement new hash API
>   crypto/hash-nettle: Implement new hash API
>   crypto/hash-afalg: Update to new API  (only add new APIs here )
>   < convert old public APIs to call the new driver APIs here>
>   tests/unit/test-crypto-hash: accumulative hashing
>   crypto/hash-glib: Remove old hash API implementation
>   crypto/hash-gcrypt: Remove old hash API implementation
>   crypto/hash-gnutls: Remove old hash API
>   crypto/hash-nettle: Remove old hash API
>   < remove old afalg support here >
>   < remove old driver APIs here >
>   hw/misc/aspeed_hace: Fix SG Accumulative hashing

Apologies, I will reorder the patches so that 'make check' works independently 
and take your other comments into account.

Thank you for the feedback,
Alejandro

Seagate Internal

reply via email to

[Prev in Thread] Current Thread [Next in Thread]