Re: [PATCH v3 5/9] target/arm: Make some MTE helpers widely available

[Gustavo Romero]

Hi Richard,

On 6/21/24 1:31 AM, Richard Henderson wrote:
> On 6/16/24 23:28, Gustavo Romero wrote:
> > @@ -287,7 +256,7 @@ uint64_t HELPER(addsubg)(CPUARMState *env, uint64_t ptr,
> >       return address_with_allocation_tag(ptr + offset, rtag);
> >   }
> > -static int load_tag1(uint64_t ptr, uint8_t *mem)
> > +inline int load_tag1(uint64_t ptr, uint8_t *mem)
> >   {
> >       int ofs = extract32(ptr, LOG2_TAG_GRANULE, 1) * 4;
> >       return extract32(*mem, ofs, 4);
> > @@ -321,7 +290,7 @@ static void check_tag_aligned(CPUARMState *env, uint64_t 
> > ptr, uintptr_t ra)
> >   }
> >   /* For use in a non-parallel context, store to the given nibble.  */
> > -static void store_tag1(uint64_t ptr, uint8_t *mem, int tag)
> > +inline void store_tag1(uint64_t ptr, uint8_t *mem, int tag)
> >   {
> >       int ofs = extract32(ptr, LOG2_TAG_GRANULE, 1) * 4;
> >       *mem = deposit32(*mem, ofs, 4, tag);
> Move these two entirely to the header as static inline.
> In general, inline without static doesn't mean what you think.
>
> With that,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Done in v4. Thanks.


Cheers,
Gustavo