Re: [PATCH] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu

[Mario Casquero]

This patch has been successfully tested. After running the numa-test
binary, now -cpu max is being used instead of the obsolete 'pentium'
one.

# starting QEMU: exec /home/qemu/build/qemu-system-x86_64 -qtest
unix:/tmp/qtest-16915.sock -qtest-log /dev/null -chardev
socket,path=/tmp/qtest-16915.qmp,id=char0 -mon
chardev=char0,mode=control -display none -audio none -object
memory-backend-ram,id=ram,size=128M -cpu max -machine
smp.cpus=8,smp.sockets=2,smp.cores=2,smp.threads=2 -numa
node,nodeid=0,memdev=ram -numa node,nodeid=1 -numa
cpu,node-id=1,socket-id=0 -numa cpu,node-id=0,socket-id=1,core-id=0
-numa cpu,node-id=0,socket-id=1,core-id=1,thread-id=0 -numa
cpu,node-id=1,socket-id=1,core-id=1,thread-id=1 -accel qtest

Tested-by: Mario Casquero <mcasquer@redhat.com>


On Tue, Jun 4, 2024 at 8:24 AM Ani Sinha <anisinha@redhat.com> wrote:
>
> 'pentium' cpu is old and obsolete and should be avoided for running tests if
> its not strictly needed. Use 'max' cpu instead for generic non-cpu specific
> numa test.
>
> CC: thuth@redhat.com
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
>  tests/qtest/numa-test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/numa-test.c b/tests/qtest/numa-test.c
> index 7aa262dbb9..f01f19592d 100644
> --- a/tests/qtest/numa-test.c
> +++ b/tests/qtest/numa-test.c
> @@ -125,7 +125,8 @@ static void pc_numa_cpu(const void *data)
>      QTestState *qts;
>      g_autofree char *cli = NULL;
>
> -    cli = make_cli(data, "-cpu pentium -machine 
> smp.cpus=8,smp.sockets=2,smp.cores=2,smp.threads=2 "
> +    cli = make_cli(data,
> +        "-cpu max -machine 
> smp.cpus=8,smp.sockets=2,smp.cores=2,smp.threads=2 "
>          "-numa node,nodeid=0,memdev=ram -numa node,nodeid=1 "
>          "-numa cpu,node-id=1,socket-id=0 "
>          "-numa cpu,node-id=0,socket-id=1,core-id=0 "
> --
> 2.42.0
>
>