qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 24/25] target/i386: do not check PREFIX_LOCK in old-style dec


From: Paolo Bonzini
Subject: Re: [PATCH 24/25] target/i386: do not check PREFIX_LOCK in old-style decoder
Date: Mon, 10 Jun 2024 19:10:56 +0200

On Sat, Jun 8, 2024 at 10:16 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 6/8/24 01:41, Paolo Bonzini wrote:
> > It is already checked before getting there.
> >
> > Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> > ---
> >   target/i386/tcg/translate.c | 26 ++++++++------------------
> >   1 file changed, 8 insertions(+), 18 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

... except cmpxchg8b/cmpxchg16b do have to accept LOCK. Fortunately
it's trivial to convert them, with just an ugly temporary

    if (decode.e.gen == gen_multi0F) {
        accept_lock = true;
    }

that only lasts one commit. I'll resend this part of the series later
(and BTx as well).

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]