Re: [PATCH v2 04/28] target/ppc: Remove unused helper

[Nicholas Piggin]

On Thu May 2, 2024 at 9:43 AM AEST, BALATON Zoltan wrote:
> The helper_rac function is defined but not used, remove it.
>
> Fixes: 005b69fdcc (target/ppc: Remove PowerPC 601 CPUs)
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Reviwed-by: Nicholas Piggin <npiggin@gmail.com>

> ---
>  target/ppc/helper.h     |  2 --
>  target/ppc/mmu_helper.c | 24 ------------------------
>  2 files changed, 26 deletions(-)
>
> diff --git a/target/ppc/helper.h b/target/ppc/helper.h
> index 86f97ee1e7..f769e01c3d 100644
> --- a/target/ppc/helper.h
> +++ b/target/ppc/helper.h
> @@ -700,8 +700,6 @@ DEF_HELPER_2(book3s_msgclr, void, env, tl)
>  
>  DEF_HELPER_4(dlmzb, tl, env, tl, tl, i32)
>  #if !defined(CONFIG_USER_ONLY)
> -DEF_HELPER_2(rac, tl, env, tl)
> -
>  DEF_HELPER_2(load_dcr, tl, env, tl)
>  DEF_HELPER_3(store_dcr, void, env, tl, tl)
>  #endif
> diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
> index c071b4d5e2..817836b731 100644
> --- a/target/ppc/mmu_helper.c
> +++ b/target/ppc/mmu_helper.c
> @@ -595,30 +595,6 @@ void helper_6xx_tlbi(CPUPPCState *env, target_ulong EPN)
>      do_6xx_tlb(env, EPN, 1);
>  }
>  
> -/*****************************************************************************/
> -/* PowerPC 601 specific instructions (POWER bridge) */
> -
> -target_ulong helper_rac(CPUPPCState *env, target_ulong addr)
> -{
> -    mmu_ctx_t ctx;
> -    int nb_BATs;
> -    target_ulong ret = 0;
> -
> -    /*
> -     * We don't have to generate many instances of this instruction,
> -     * as rac is supervisor only.
> -     *
> -     * XXX: FIX THIS: Pretend we have no BAT
> -     */
> -    nb_BATs = env->nb_BATs;
> -    env->nb_BATs = 0;
> -    if (get_physical_address_wtlb(env, &ctx, addr, 0, ACCESS_INT, 0) == 0) {
> -        ret = ctx.raddr;
> -    }
> -    env->nb_BATs = nb_BATs;
> -    return ret;
> -}
> -
>  static inline target_ulong booke_tlb_to_page_size(int size)
>  {
>      return 1024 << (2 * size);