Re: [PATCH v2 09/12] accel/tcg: Restrict cpu_loop_exit_requested() to TCG

[Philippe Mathieu-Daudé]

On 29/4/24 00:17, Philippe Mathieu-Daudé wrote:
> On 29/4/24 00:08, Richard Henderson wrote:
> > On 4/28/24 14:49, Philippe Mathieu-Daudé wrote:
> > > cpu_loop_exit_requested() is specific to TCG, move it
> > > to "exec/translate-all.h".
> > >
> > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> > > ---
> > >   include/exec/exec-all.h       | 17 -----------------
> > >   include/exec/translate-all.h  | 20 ++++++++++++++++++++
> > >   target/arm/tcg/helper-a64.c   |  1 +
> > >   target/s390x/tcg/mem_helper.c |  1 +
> > >   4 files changed, 22 insertions(+), 17 deletions(-)
> >
> > I guess we could dither about whether this is the best place, but I 
> > guess it doesn't matter.  Do you really need the CONFIG_TCG ifdef?
>
> Right, actually 50 patches later it ends in "exec/cpu-loop.h",
> and "exec/translate-all.h" is removed. I need to check whether
> or not this patch is required at this stage, maybe not. Otherwise
> I'll directly introduce "exec/cpu-loop.h" I guess.

So we need it at this point because cpu_loop_exit_requested()
access neg.icount_decr, which we'll restrict in few commits
(I'll mention that in the commit description).

In "exec/translate-all.h" we don't need the CONFIG_TCG #ifdef,
but we'll need it in "exec/cpu-loop.h".

> > Either way,
> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> >
> >
> > r~