Re: [PATCH 3/5] target/alpha: Split out gen_goto_tb

[Richard Henderson]

On 4/29/24 09:58, Philippe Mathieu-Daudé wrote:
> On 25/4/24 01:44, Richard Henderson wrote:
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   target/alpha/translate.c | 61 ++++++++++++++--------------------------
> >   1 file changed, 21 insertions(+), 40 deletions(-)
>
>
> >   static DisasJumpType gen_bdirect(DisasContext *ctx, int ra, int32_t disp)
> >   {
>
> >       /* Notice branch-to-next; used to initialize RA with the PC.  */
> >       if (disp == 0) {
> > -        return 0;
>
> This is the single case in the code base of returning a non-DISAS_foo
> as DisasJumpType :)
>
> > +        return DISAS_NEXT;

Yes.  Note that DISAS_NEXT == 0, so this worked accidentally.
But of course using the correct name is better.

r~