[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] migration: Add direct-io parameter
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 4/9] migration: Add direct-io parameter |
Date: |
Fri, 26 Apr 2024 16:33:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Fabiano Rosas <farosas@suse.de> writes:
> Add the direct-io migration parameter that tells the migration code to
> use O_DIRECT when opening the migration stream file whenever possible.
>
> This is currently only used with the mapped-ram migration that has a
> clear window guaranteed to perform aligned writes.
>
> Acked-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 8c65b90328..1a8a4b114c 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -914,6 +914,9 @@
> # See description in @ZeroPageDetection. Default is 'multifd'.
> # (since 9.0)
> #
> +# @direct-io: Open migration files with O_DIRECT when possible. This
> +# requires that the @mapped-ram capability is enabled. (since 9.1)
> +#
Two spaces between sentences for consistency, please.
> # Features:
> #
> # @deprecated: Member @block-incremental is deprecated. Use
> @@ -948,7 +951,8 @@
> { 'name': 'x-vcpu-dirty-limit-period', 'features': ['unstable'] },
> 'vcpu-dirty-limit',
> 'mode',
> - 'zero-page-detection'] }
> + 'zero-page-detection',
> + 'direct-io'] }
>
> ##
> # @MigrateSetParameters:
[...]
- [PATCH 0/9] migration/mapped-ram: Add direct-io support, Fabiano Rosas, 2024/04/26
- [PATCH 1/9] monitor: Honor QMP request for fd removal immediately, Fabiano Rosas, 2024/04/26
- [PATCH 2/9] migration: Fix file migration with fdset, Fabiano Rosas, 2024/04/26
- [PATCH 3/9] tests/qtest/migration: Fix file migration offset check, Fabiano Rosas, 2024/04/26
- [PATCH 4/9] migration: Add direct-io parameter, Fabiano Rosas, 2024/04/26
- Re: [PATCH 4/9] migration: Add direct-io parameter,
Markus Armbruster <=
- [PATCH 8/9] migration: Add support for fdset with multifd + file, Fabiano Rosas, 2024/04/26
- [PATCH 9/9] tests/qtest/migration: Add a test for mapped-ram with passing of fds, Fabiano Rosas, 2024/04/26
- [PATCH 6/9] tests/qtest/migration: Add tests for file migration with direct-io, Fabiano Rosas, 2024/04/26
- [PATCH 7/9] monitor: fdset: Match against O_DIRECT, Fabiano Rosas, 2024/04/26
- [PATCH 5/9] migration/multifd: Add direct-io support, Fabiano Rosas, 2024/04/26