[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 25/33] target/i386: Use translator_ldub for everything
From: |
Richard Henderson |
Subject: |
[PATCH v2 25/33] target/i386: Use translator_ldub for everything |
Date: |
Wed, 24 Apr 2024 16:31:23 -0700 |
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/i386/tcg/translate.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 6658adc4bc..6f04a77eed 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -23,7 +23,6 @@
#include "exec/exec-all.h"
#include "tcg/tcg-op.h"
#include "tcg/tcg-op-gvec.h"
-#include "exec/cpu_ldst.h"
#include "exec/translator.h"
#include "fpu/softfloat.h"
@@ -2138,9 +2137,8 @@ static uint64_t advance_pc(CPUX86State *env, DisasContext
*s, int num_bytes)
* This can happen even if the operand is only one byte long!
*/
if (((s->pc - 1) ^ (pc - 1)) & TARGET_PAGE_MASK) {
- volatile uint8_t unused =
- cpu_ldub_code(env, (s->pc - 1) & TARGET_PAGE_MASK);
- (void) unused;
+ (void)translator_ldub(env, &s->base,
+ (s->pc - 1) & TARGET_PAGE_MASK);
}
siglongjmp(s->jmpbuf, 1);
}
@@ -2718,7 +2716,7 @@ static void gen_unknown_opcode(CPUX86State *env,
DisasContext *s)
fprintf(logfile, "ILLOPC: " TARGET_FMT_lx ":", pc);
for (; pc < end; ++pc) {
- fprintf(logfile, " %02x", cpu_ldub_code(env, pc));
+ fprintf(logfile, " %02x", translator_ldub(env, &s->base, pc));
}
fprintf(logfile, "\n");
qemu_log_unlock(logfile);
--
2.34.1
- [PATCH v2 19/33] disas: Use translator_st to get disassembly data, (continued)
- [PATCH v2 19/33] disas: Use translator_st to get disassembly data, Richard Henderson, 2024/04/24
- [PATCH v2 22/33] target/s390x: Disassemble EXECUTEd instructions, Richard Henderson, 2024/04/24
- [PATCH v2 23/33] target/hexagon: Use translator_ldl in pkt_crosses_page, Richard Henderson, 2024/04/24
- [PATCH v2 20/33] accel/tcg: Introduce translator_fake_ld, Richard Henderson, 2024/04/24
- [PATCH v2 18/33] disas: Split disas.c, Richard Henderson, 2024/04/24
- [PATCH v2 21/33] target/s390x: Fix translator_fake_ld length, Richard Henderson, 2024/04/24
- [PATCH v2 24/33] target/microblaze: Use translator_ldl, Richard Henderson, 2024/04/24
- [PATCH v2 27/33] target/cris: Use translator_ld* in cris_fetch, Richard Henderson, 2024/04/24
- [PATCH v2 33/33] accel/tcg: Remove cpu_ldsb_code / cpu_ldsw_code, Richard Henderson, 2024/04/24
- [PATCH v2 25/33] target/i386: Use translator_ldub for everything,
Richard Henderson <=
- [PATCH v2 26/33] target/avr: Use translator_lduw, Richard Henderson, 2024/04/24
- [PATCH v2 29/33] target/riscv: Use translator_ld* for everything, Richard Henderson, 2024/04/24
- [PATCH v2 30/33] target/rx: Use translator_ld*, Richard Henderson, 2024/04/24
- [PATCH v2 28/33] target/cris: Use cris_fetch in translate_v10.c.inc, Richard Henderson, 2024/04/24
- [PATCH v2 31/33] target/xtensa: Use translator_ldub in xtensa_insn_len, Richard Henderson, 2024/04/24
- [PATCH v2 32/33] target/s390x: Use translator_lduw in get_next_pc, Richard Henderson, 2024/04/24
- Re: [PATCH v2 00/33] accel/tcg: Improve disassembly for target and plugin, Philippe Mathieu-Daudé, 2024/04/29