[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 14/33] plugins: Use DisasContextBase for qemu_plugin_tb_vaddr
From: |
Richard Henderson |
Subject: |
[PATCH v2 14/33] plugins: Use DisasContextBase for qemu_plugin_tb_vaddr |
Date: |
Wed, 24 Apr 2024 16:31:12 -0700 |
We do not need to separately record the start of the TB.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/qemu/plugin.h | 1 -
accel/tcg/plugin-gen.c | 3 +--
plugins/api.c | 3 ++-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h
index 3db0e75d16..340e10ef12 100644
--- a/include/qemu/plugin.h
+++ b/include/qemu/plugin.h
@@ -117,7 +117,6 @@ struct qemu_plugin_scoreboard {
struct qemu_plugin_tb {
GPtrArray *insns;
size_t n;
- uint64_t vaddr;
/* if set, the TB calls helpers that might access guest memory */
bool mem_helper;
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
index b036773d3c..2c52306f80 100644
--- a/accel/tcg/plugin-gen.c
+++ b/accel/tcg/plugin-gen.c
@@ -188,7 +188,7 @@ static void plugin_gen_inject(struct qemu_plugin_tb
*plugin_tb)
int insn_idx = -1;
if (unlikely(qemu_loglevel_mask(LOG_TB_OP_PLUGIN)
- && qemu_log_in_addr_range(plugin_tb->vaddr))) {
+ && qemu_log_in_addr_range(tcg_ctx->plugin_db->pc_first))) {
FILE *logfile = qemu_log_trylock();
if (logfile) {
fprintf(logfile, "OP before plugin injection:\n");
@@ -318,7 +318,6 @@ bool plugin_gen_tb_start(CPUState *cpu, const
DisasContextBase *db)
ret = true;
- ptb->vaddr = db->pc_first;
ptb->mem_helper = false;
tcg_gen_plugin_cb(PLUGIN_GEN_FROM_TB);
diff --git a/plugins/api.c b/plugins/api.c
index 4b6690c7d6..36ab47cdae 100644
--- a/plugins/api.c
+++ b/plugins/api.c
@@ -200,7 +200,8 @@ size_t qemu_plugin_tb_n_insns(const struct qemu_plugin_tb
*tb)
uint64_t qemu_plugin_tb_vaddr(const struct qemu_plugin_tb *tb)
{
- return tb->vaddr;
+ const DisasContextBase *db = tcg_ctx->plugin_db;
+ return db->pc_first;
}
struct qemu_plugin_insn *
--
2.34.1
- [PATCH v2 09/33] plugins: Copy memory in qemu_plugin_insn_data, (continued)
- [PATCH v2 09/33] plugins: Copy memory in qemu_plugin_insn_data, Richard Henderson, 2024/04/24
- [PATCH v2 08/33] accel/tcg: Record DisasContextBase in tcg_ctx for plugins, Richard Henderson, 2024/04/24
- [PATCH v2 10/33] accel/tcg: Implement translator_st, Richard Henderson, 2024/04/24
- [PATCH v2 06/33] accel/tcg: Record mmio bytes during translation, Richard Henderson, 2024/04/24
- [PATCH v2 12/33] plugins: Read mem_only directly from TB cflags, Richard Henderson, 2024/04/24
- [PATCH v2 17/33] accel/tcg: Return bool from TranslatorOps.disas_log, Richard Henderson, 2024/04/24
- [PATCH v2 16/33] accel/tcg: Provide default implementation of disas_log, Richard Henderson, 2024/04/24
- [PATCH v2 14/33] plugins: Use DisasContextBase for qemu_plugin_tb_vaddr,
Richard Henderson <=
- [PATCH v2 13/33] plugins: Use DisasContextBase for qemu_plugin_insn_haddr, Richard Henderson, 2024/04/24
- [PATCH v2 15/33] plugins: Merge alloc_tcg_plugin_context into plugin_gen_tb_start, Richard Henderson, 2024/04/24
- [PATCH v2 19/33] disas: Use translator_st to get disassembly data, Richard Henderson, 2024/04/24
- [PATCH v2 22/33] target/s390x: Disassemble EXECUTEd instructions, Richard Henderson, 2024/04/24
- [PATCH v2 23/33] target/hexagon: Use translator_ldl in pkt_crosses_page, Richard Henderson, 2024/04/24
- [PATCH v2 20/33] accel/tcg: Introduce translator_fake_ld, Richard Henderson, 2024/04/24
- [PATCH v2 18/33] disas: Split disas.c, Richard Henderson, 2024/04/24
- [PATCH v2 21/33] target/s390x: Fix translator_fake_ld length, Richard Henderson, 2024/04/24
- [PATCH v2 24/33] target/microblaze: Use translator_ldl, Richard Henderson, 2024/04/24