[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 13/20] tcg: Remove INDEX_op_plugin_cb_{start,end}
From: |
Richard Henderson |
Subject: |
[PATCH v3 13/20] tcg: Remove INDEX_op_plugin_cb_{start,end} |
Date: |
Wed, 24 Apr 2024 16:02:17 -0700 |
These opcodes are no longer used.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/tcg/tcg-op-common.h | 2 --
include/tcg/tcg-opc.h | 2 --
accel/tcg/plugin-gen.c | 18 ------------------
tcg/tcg-op.c | 10 ----------
4 files changed, 32 deletions(-)
diff --git a/include/tcg/tcg-op-common.h b/include/tcg/tcg-op-common.h
index 72b80b20d0..009e2778c5 100644
--- a/include/tcg/tcg-op-common.h
+++ b/include/tcg/tcg-op-common.h
@@ -76,8 +76,6 @@ void tcg_gen_lookup_and_goto_ptr(void);
void tcg_gen_plugin_cb(unsigned from);
void tcg_gen_plugin_mem_cb(TCGv_i64 addr, unsigned meminfo);
-void tcg_gen_plugin_cb_start(unsigned from, unsigned type, unsigned wr);
-void tcg_gen_plugin_cb_end(void);
/* 32 bit ops */
diff --git a/include/tcg/tcg-opc.h b/include/tcg/tcg-opc.h
index be9e36e386..546eb49c11 100644
--- a/include/tcg/tcg-opc.h
+++ b/include/tcg/tcg-opc.h
@@ -199,8 +199,6 @@ DEF(goto_ptr, 0, 1, 0, TCG_OPF_BB_EXIT | TCG_OPF_BB_END)
DEF(plugin_cb, 0, 0, 1, TCG_OPF_NOT_PRESENT)
DEF(plugin_mem_cb, 0, 1, 1, TCG_OPF_NOT_PRESENT)
-DEF(plugin_cb_start, 0, 0, 3, TCG_OPF_NOT_PRESENT)
-DEF(plugin_cb_end, 0, 0, 0, TCG_OPF_NOT_PRESENT)
/* Replicate ld/st ops for 32 and 64-bit guest addresses. */
DEF(qemu_ld_a32_i32, 1, 1, 1,
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c
index fb77585ac0..d9ee9bb2ec 100644
--- a/accel/tcg/plugin-gen.c
+++ b/accel/tcg/plugin-gen.c
@@ -52,29 +52,11 @@
#include "exec/plugin-gen.h"
#include "exec/translator.h"
-/*
- * plugin_cb_start TCG op args[]:
- * 0: enum plugin_gen_from
- * 1: enum plugin_gen_cb
- * 2: set to 1 for mem callback that is a write, 0 otherwise.
- */
-
enum plugin_gen_from {
PLUGIN_GEN_FROM_TB,
PLUGIN_GEN_FROM_INSN,
PLUGIN_GEN_AFTER_INSN,
PLUGIN_GEN_AFTER_TB,
- PLUGIN_GEN_N_FROMS,
-};
-
-enum plugin_gen_cb {
- PLUGIN_GEN_CB_UDATA,
- PLUGIN_GEN_CB_UDATA_R,
- PLUGIN_GEN_CB_INLINE,
- PLUGIN_GEN_CB_MEM,
- PLUGIN_GEN_ENABLE_MEM_HELPER,
- PLUGIN_GEN_DISABLE_MEM_HELPER,
- PLUGIN_GEN_N_CBS,
};
static void plugin_gen_empty_callback(enum plugin_gen_from from)
diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
index 0ae12fa49d..eff3728622 100644
--- a/tcg/tcg-op.c
+++ b/tcg/tcg-op.c
@@ -322,16 +322,6 @@ void tcg_gen_plugin_mem_cb(TCGv_i64 addr, unsigned meminfo)
tcg_gen_op2(INDEX_op_plugin_mem_cb, tcgv_i64_arg(addr), meminfo);
}
-void tcg_gen_plugin_cb_start(unsigned from, unsigned type, unsigned wr)
-{
- tcg_gen_op3(INDEX_op_plugin_cb_start, from, type, wr);
-}
-
-void tcg_gen_plugin_cb_end(void)
-{
- tcg_emit_op(INDEX_op_plugin_cb_end, 0);
-}
-
/* 32 bit ops */
void tcg_gen_discard_i32(TCGv_i32 arg)
--
2.34.1
- [PATCH v3 02/20] tcg: Pass function pointer to tcg_gen_call*, (continued)
- [PATCH v3 02/20] tcg: Pass function pointer to tcg_gen_call*, Richard Henderson, 2024/04/24
- [PATCH v3 04/20] plugins: Move function pointer in qemu_plugin_dyn_cb, Richard Henderson, 2024/04/24
- [PATCH v3 05/20] plugins: Create TCGHelperInfo for all out-of-line callbacks, Richard Henderson, 2024/04/24
- [PATCH v3 06/20] plugins: Use emit_before_op for PLUGIN_GEN_AFTER_INSN, Richard Henderson, 2024/04/24
- [PATCH v3 07/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_TB, Richard Henderson, 2024/04/24
- [PATCH v3 08/20] plugins: Add PLUGIN_GEN_AFTER_TB, Richard Henderson, 2024/04/24
- [PATCH v3 09/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_INSN, Richard Henderson, 2024/04/24
- [PATCH v3 11/20] plugins: Remove plugin helpers, Richard Henderson, 2024/04/24
- [PATCH v3 10/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_MEM, Richard Henderson, 2024/04/24
- [PATCH v3 12/20] tcg: Remove TCG_CALL_PLUGIN, Richard Henderson, 2024/04/24
- [PATCH v3 13/20] tcg: Remove INDEX_op_plugin_cb_{start,end},
Richard Henderson <=
- [PATCH v3 14/20] plugins: Simplify callback queues, Richard Henderson, 2024/04/24
- [PATCH v3 15/20] plugins: Introduce PLUGIN_CB_MEM_REGULAR, Richard Henderson, 2024/04/24
- [PATCH v3 17/20] plugins: Split out common cb expanders, Richard Henderson, 2024/04/24
- [PATCH v3 18/20] plugins: Merge qemu_plugin_tb_insn_get to plugin-gen.c, Richard Henderson, 2024/04/24
- [PATCH v3 16/20] plugins: Replace pr_ops with a proper debug dump flag, Richard Henderson, 2024/04/24
- [PATCH v3 19/20] plugins: Inline plugin_gen_empty_callback, Richard Henderson, 2024/04/24
- [PATCH v3 20/20] plugins: Update the documentation block for plugin-gen.c, Richard Henderson, 2024/04/24