[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/10] qapi: Correct error message for 'vcpu_dirty_limit' paramete
From: |
Markus Armbruster |
Subject: |
[PULL 08/10] qapi: Correct error message for 'vcpu_dirty_limit' parameter |
Date: |
Wed, 24 Apr 2024 10:03:35 +0200 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
QERR_INVALID_PARAMETER_VALUE is defined as:
#define QERR_INVALID_PARAMETER_VALUE \
"Parameter '%s' expects %s"
The current error is formatted as:
"Parameter 'vcpu_dirty_limit' expects is invalid, it must greater then 1 MB/s"
Replace by:
"Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s"
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240312141343.3168265-9-armbru@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
[New error message corrected, commit message updated accordingly]
---
migration/options.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/migration/options.c b/migration/options.c
index bfd7753b69..d7a773aea8 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -1286,9 +1286,8 @@ bool migrate_params_check(MigrationParameters *params,
Error **errp)
if (params->has_vcpu_dirty_limit &&
(params->vcpu_dirty_limit < 1)) {
- error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
- "vcpu_dirty_limit",
- "is invalid, it must greater then 1 MB/s");
+ error_setg(errp,
+ "Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s");
return false;
}
--
2.44.0
- [PULL 00/10] Error reporting patches for 2024-04-24, Markus Armbruster, 2024/04/24
- [PULL 07/10] qapi: Inline and remove QERR_INVALID_PARAMETER_TYPE definition, Markus Armbruster, 2024/04/24
- [PULL 04/10] qapi: Inline and remove QERR_DEVICE_NO_HOTPLUG definition, Markus Armbruster, 2024/04/24
- [PULL 09/10] qapi: Inline and remove QERR_MIGRATION_ACTIVE definition, Markus Armbruster, 2024/04/24
- [PULL 02/10] qapi: Inline and remove QERR_BUS_NO_HOTPLUG definition, Markus Armbruster, 2024/04/24
- [PULL 05/10] qapi: Inline and remove QERR_INVALID_PARAMETER definition, Markus Armbruster, 2024/04/24
- [PULL 08/10] qapi: Correct error message for 'vcpu_dirty_limit' parameter,
Markus Armbruster <=
- [PULL 03/10] qapi: Inline and remove QERR_DEVICE_HAS_NO_MEDIUM definition, Markus Armbruster, 2024/04/24
- [PULL 06/10] qapi: Inline QERR_INVALID_PARAMETER_TYPE definition (constant value), Markus Armbruster, 2024/04/24
- [PULL 01/10] error: Drop superfluous #include "qapi/qmp/qerror.h", Markus Armbruster, 2024/04/24
- [PULL 10/10] qapi: Inline and remove QERR_PROPERTY_VALUE_BAD definition, Markus Armbruster, 2024/04/24
- Re: [PULL 00/10] Error reporting patches for 2024-04-24, Richard Henderson, 2024/04/24