Re: [PATCH v7 0/5] ui/console: Private QemuDmaBuf struct

[Philippe Mathieu-Daudé]

On 19/4/24 00:05, dongwon.kim@intel.com wrote:
> From: Dongwon Kim <dongwon.kim@intel.com>
>
> This series introduces privacy enhancements to the QemuDmaBuf struct
> and its contained data to bolster security. it accomplishes this by
> introducing of helper functions for allocating, deallocating, and
> accessing individual fields within the struct and replacing all direct
> references to individual fields in the struct with methods using helpers
> throughout the codebase.
>
> This change was made based on a suggestion from Marc-André Lureau
> <marcandre.lureau@redhat.com>


> Dongwon Kim (5):
>    ui/gtk: Check if fence_fd is equal to or greater than 0
>    ui/console: Introduce qemu_dmabuf_get_..() helpers
>    ui/console: Introduce qemu_dmabuf_set_..() helpers
>    ui/console: Introduce qemu_dmabuf_new() and free() helpers
>    ui/dmabuf: New dmabuf.c and dmabuf.h for QemuDmaBuf struct and helpers

Instead of introducing then moving code, you could re-order
patches as 1, 5, 2, 3, 4 (in patch 2, introduce helper in
new dmabuf.c file and new header).