Re: [PATCH v5 0/3] Add support for the RAPL MSRs series

[Daniel P . Berrangé]

On Fri, Apr 12, 2024 at 12:57:11PM +0200, Paolo Bonzini wrote:
> On Thu, Apr 11, 2024 at 2:14 PM Anthony Harivel <aharivel@redhat.com> wrote:
> >
> > Dear maintainers,
> >
> > First of all, thank you very much for your review of my patch
> > [1].
> >
> > In this version (v5), I have attempted to address all the problems
> > addressed by Daniel during the last review. I've been more careful with
> > all the remarks made.
> >
> > However, one question remains unanswered pointing the issue with the
> > location of "/var/local/run/qemu-vmsr-helper.sock", created by
> > compute_default_paths(). QEMU is not allowed to reach the socket here.
> 
> If I understand correctly the question, that is expected. This is a
> privileged functionality and therefore it requires manual intervention
> to change the owner of the socket and allow QEMU to access it.

In the systemd case, it will set the owner and mode, but in the
non-system case, I wonder if it worth making this helper program
have "--socket-owner" and "--socket-mode" args, so it can create
the socket with the right mode/owner immediately, rather than
expecting the admin to manuall chmod+chown after start the
helper


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|