Re: [PATCH for-9.0] ppc440_pcix: Do not expose a bridge device on PCI bus

[Nicholas Piggin]

On Tue Apr 16, 2024 at 7:43 PM AEST, BALATON Zoltan wrote:
> On Tue, 16 Apr 2024, Nicholas Piggin wrote:
> > On Wed Apr 10, 2024 at 9:03 PM AEST, BALATON Zoltan wrote:
> >> On Wed, 10 Apr 2024, Nicholas Piggin wrote:
> >>> On Wed Apr 10, 2024 at 9:55 AM AEST, BALATON Zoltan wrote:
> >>>> Real 460EX SoC apparently does not expose a bridge device and having
> >>>> it appear on PCI bus confuses an AmigaOS file system driver that uses
> >>>> this to detect which machine it is running on. Since values written
> >>>> here by firmware are never read, just ignore these writes and drop the
> >>>> bridge device.
> >>>>
> >>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> >>>> ---
> >>>> This is only used by sam460ex and this fixes an issue with AmigaOS on
> >>>> this machine so I'd like this to be merged for 9.0 please.
> >>>
> >>> Is it a regression? Does it have a fixes: or resolves: tag?
> >>>
> >>> Unless we broke it in this cycle, I would be inclined to wait,
> >>> and we can ask to put it in stable.
> >>
> >> It's not something that broke in this cycle but since this does not affect
> >> anything else than sam460ex I think it's OK to change this for 9.0. The
> >> changes to 440 tlb in this cycle made sam460ex more useful to run AmigaOS
> >> and this fixes the file system driver on it so it would make 9.0 really
> >> usable. Otherwise people would have to wait longer until August or install
> >> a stable update. Since this has low chance to break anything (tested with
> >> AmogaOS and Linux and MorphOS does not boot due to do_io changes anyway) I
> >> don't think we have to wait with this.
> >
> > Hey, travelling / at a conference / on vacation for the next couple of
> > weeks.
> >
> > It's just a bit late for hard freeze IMO, since we didn't break it
> > before the prior release or a bad security / crash bug. Will put it in
> > 9.1.
>
> Philippe already queued this (and another) patch. This fixes AmigaOS on 
> sam460ex which became usable with the tlbwe changes in this cycle but it's 
> not really usable without a file system driver that this patch fixes. 
> Please allow this in 9.0 so users who want to try it don't have to wait a 
> few months more. Sorry for sending it this late but it was reported late 
> and took time to debug it.

No worries, I don't have a problem with the patch so if Philippe
thinks it's okay then I'm fine with that.

Thanks,
Nick