[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 14/22] hw/mem/pc-dimm: Remove legacy_align argument from pc_di
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v4 14/22] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug() |
Date: |
Tue, 16 Apr 2024 20:59:30 +0200 |
'legacy_align' is always NULL, remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
---
include/hw/mem/pc-dimm.h | 3 +--
hw/arm/virt.c | 2 +-
hw/i386/pc.c | 2 +-
hw/loongarch/virt.c | 2 +-
hw/mem/pc-dimm.c | 6 ++----
hw/ppc/spapr.c | 2 +-
6 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index 322bebe555..fe0f3ea963 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -66,8 +66,7 @@ struct PCDIMMDeviceClass {
void (*unrealize)(PCDIMMDevice *dimm);
};
-void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine,
- const uint64_t *legacy_align, Error **errp);
+void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine, Error **errp);
void pc_dimm_plug(PCDIMMDevice *dimm, MachineState *machine);
void pc_dimm_unplug(PCDIMMDevice *dimm, MachineState *machine);
#endif
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index a55ef916cb..7af05a6a2d 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2736,7 +2736,7 @@ static void virt_memory_pre_plug(HotplugHandler
*hotplug_dev, DeviceState *dev,
return;
}
- pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), NULL, errp);
+ pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), errp);
}
static void virt_memory_plug(HotplugHandler *hotplug_dev,
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index c7bfdfc1e1..9ba21b9967 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1309,7 +1309,7 @@ static void pc_memory_pre_plug(HotplugHandler
*hotplug_dev, DeviceState *dev,
return;
}
- pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), NULL, errp);
+ pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), errp);
}
static void pc_memory_plug(HotplugHandler *hotplug_dev,
diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
index 00d3005e54..af71bd2a99 100644
--- a/hw/loongarch/virt.c
+++ b/hw/loongarch/virt.c
@@ -1025,7 +1025,7 @@ static bool memhp_type_supported(DeviceState *dev)
static void virt_mem_pre_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
Error **errp)
{
- pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), NULL, errp);
+ pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), errp);
}
static void virt_machine_device_pre_plug(HotplugHandler *hotplug_dev,
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 37f1f4ccfd..836384a90f 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -44,8 +44,7 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice
*dimm, Error **errp)
return host_memory_backend_get_memory(dimm->hostmem);
}
-void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine,
- const uint64_t *legacy_align, Error **errp)
+void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine, Error **errp)
{
Error *local_err = NULL;
int slot;
@@ -70,8 +69,7 @@ void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState
*machine,
&error_abort);
trace_mhp_pc_dimm_assigned_slot(slot);
- memory_device_pre_plug(MEMORY_DEVICE(dimm), machine, legacy_align,
- errp);
+ memory_device_pre_plug(MEMORY_DEVICE(dimm), machine, NULL, errp);
}
void pc_dimm_plug(PCDIMMDevice *dimm, MachineState *machine)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index e9bc97fee0..f147876dc9 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3668,7 +3668,7 @@ static void spapr_memory_pre_plug(HotplugHandler
*hotplug_dev, DeviceState *dev,
return;
}
- pc_dimm_pre_plug(dimm, MACHINE(hotplug_dev), NULL, errp);
+ pc_dimm_pre_plug(dimm, MACHINE(hotplug_dev), errp);
}
struct SpaprDimmState {
--
2.41.0
- [PATCH v4 04/22] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag, (continued)
- [PATCH v4 04/22] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 05/22] hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 07/22] hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug', Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 06/22] hw/acpi/ich9: Remove 'memory-hotplug-support' property, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 08/22] hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 09/22] target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h', Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 10/22] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 11/22] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults(), Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 12/22] hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid(), Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 13/22] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 14/22] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug(),
Philippe Mathieu-Daudé <=
- [PATCH v4 15/22] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug(), Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 16/22] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 17/22] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 18/22] hw/i386/pc: Remove PCMachineClass::rsdp_in_ram, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 20/22] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 21/22] target/i386: Remove X86CPU::kvm_no_smi_migration field, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 19/22] hw/i386/acpi: Remove AcpiBuildState::rsdp field, Philippe Mathieu-Daudé, 2024/04/16
- [PATCH v4 22/22] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE, Philippe Mathieu-Daudé, 2024/04/16
- Re: [PATCH v4 00/22] hw/i386: Remove deprecated pc-i440fx-2.0 -> 2.3 machines, Philippe Mathieu-Daudé, 2024/04/24