qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/6] hw, target: Add ResetType argument to hold and exit phas


From: Richard Henderson
Subject: Re: [PATCH 4/6] hw, target: Add ResetType argument to hold and exit phase methods
Date: Fri, 12 Apr 2024 10:27:18 -0700
User-agent: Mozilla Thunderbird

On 4/12/24 09:08, Peter Maydell wrote:
We pass a ResetType argument to the Resettable class enter
phase method, but we don't pass it to hold and exit, even though
the callsites have it readily available. This means that if
a device cared about the ResetType it would need to record it
in the enter phase method to use later on. Pass the type to
all three of the phase methods to avoid having to do that.

Commit created with

   for dir in hw target include; do \
       spatch --macro-file scripts/cocci-macro-file.h \
              --sp-file scripts/coccinelle/reset-type.cocci \
              --keep-comments --smpl-spacing --in-place \
              --include-headers --dir $dir; done

and no manual edits.

Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]