[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 24/27] hw/net/rocker: Replace sprintf() by snprintf()
From: |
Richard Henderson |
Subject: |
[PATCH v3 24/27] hw/net/rocker: Replace sprintf() by snprintf() |
Date: |
Fri, 12 Apr 2024 00:33:43 -0700 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
resulting in painful developper experience. Use snprintf() instead.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240411104340.6617-7-philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/net/rocker/rocker.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
index 7ea8eb6ba5..03ac7a7ae9 100644
--- a/hw/net/rocker/rocker.c
+++ b/hw/net/rocker/rocker.c
@@ -915,40 +915,40 @@ static const char *rocker_reg_name(void *opaque, hwaddr
addr)
switch (index) {
case 0:
- sprintf(ring_name, "cmd");
+ snprintf(ring_name, sizeof(ring_name), "cmd");
break;
case 1:
- sprintf(ring_name, "event");
+ snprintf(ring_name, sizeof(ring_name), "event");
break;
default:
- sprintf(ring_name, "%s-%d", index % 2 ? "rx" : "tx",
- (index - 2) / 2);
+ snprintf(ring_name, sizeof(ring_name), "%s-%d",
+ index % 2 ? "rx" : "tx", (index - 2) / 2);
}
switch (offset) {
case ROCKER_DMA_DESC_ADDR_OFFSET:
- sprintf(buf, "Ring[%s] ADDR", ring_name);
+ snprintf(buf, sizeofbuf), "Ring[%s] ADDR", ring_name);
return buf;
case ROCKER_DMA_DESC_ADDR_OFFSET+4:
- sprintf(buf, "Ring[%s] ADDR+4", ring_name);
+ snprintf(buf, sizeofbuf), "Ring[%s] ADDR+4", ring_name);
return buf;
case ROCKER_DMA_DESC_SIZE_OFFSET:
- sprintf(buf, "Ring[%s] SIZE", ring_name);
+ snprintf(buf, sizeofbuf), "Ring[%s] SIZE", ring_name);
return buf;
case ROCKER_DMA_DESC_HEAD_OFFSET:
- sprintf(buf, "Ring[%s] HEAD", ring_name);
+ snprintf(buf, sizeofbuf), "Ring[%s] HEAD", ring_name);
return buf;
case ROCKER_DMA_DESC_TAIL_OFFSET:
- sprintf(buf, "Ring[%s] TAIL", ring_name);
+ snprintf(buf, sizeofbuf), "Ring[%s] TAIL", ring_name);
return buf;
case ROCKER_DMA_DESC_CTRL_OFFSET:
- sprintf(buf, "Ring[%s] CTRL", ring_name);
+ snprintf(buf, sizeofbuf), "Ring[%s] CTRL", ring_name);
return buf;
case ROCKER_DMA_DESC_CREDITS_OFFSET:
- sprintf(buf, "Ring[%s] CREDITS", ring_name);
+ snprintf(buf, sizeofbuf), "Ring[%s] CREDITS", ring_name);
return buf;
default:
- sprintf(buf, "Ring[%s] ???", ring_name);
+ snprintf(buf, sizeofbuf), "Ring[%s] ???", ring_name);
return buf;
}
} else {
--
2.34.1
- [PATCH v3 17/27] disas/microblaze: Print registers directly with PRIreg, (continued)
- [PATCH v3 17/27] disas/microblaze: Print registers directly with PRIreg, Richard Henderson, 2024/04/12
- [PATCH v3 23/27] hw/misc/imx: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 18/27] disas/microblaze: Print immediates directly with PRIimm, Richard Henderson, 2024/04/12
- [PATCH v3 26/27] target/arm: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 22/27] linux-user/flatload: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 21/27] disas/riscv: Use GString in format_inst, Richard Henderson, 2024/04/12
- [PATCH v3 25/27] hw/riscv/virt: Replace sprintf by g_strdup_printf, Richard Henderson, 2024/04/12
- [PATCH v3 19/27] disas/microblaze: Print registers directly with PRIrfsl, Richard Henderson, 2024/04/12
- [PATCH v3 20/27] disas/microblaze: Split get_field_special, Richard Henderson, 2024/04/12
- [PATCH v3 24/27] hw/net/rocker: Replace sprintf() by snprintf(),
Richard Henderson <=
- [PATCH v3 27/27] target/i386/kvm: Improve KVM_EXIT_NOTIFY warnings, Richard Henderson, 2024/04/12