Re: [PATCH for-9.1 08/19] target/i386: allow instructions with more than one immediate

[Richard Henderson]

On 4/9/24 06:43, Paolo Bonzini wrote:
> While keeping decode->immediate for convenience and for 4-operand instructions,
> store the immediate in X86DecodedOp as well.  This enables instructions
> with more than one immediate such as ENTER.  It can also be used for far
> calls and jumps.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   target/i386/tcg/decode-new.h     | 17 ++++++++++++-----
>   target/i386/tcg/decode-new.c.inc |  2 +-
>   target/i386/tcg/emit.c.inc       |  4 +++-
>   3 files changed, 16 insertions(+), 7 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> +    assert (op->unit == X86_OP_MMX || op->unit == X86_OP_SSE);

Extra space before (.


r~