qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 5/7] vdpa-dev: Fix the issue of device status not updating whe


From: Michael Tokarev
Subject: Re: [PULL 5/7] vdpa-dev: Fix the issue of device status not updating when configuration interruption is triggered
Date: Tue, 9 Apr 2024 21:06:04 +0300
User-agent: Mozilla Thunderbird

09.04.2024 20:43, Michael Tokarev:
09.04.2024 10:32, Michael S. Tsirkin:
From: lyx634449800 <yuxue.liu@jaguarmicro.com>

The set_config callback function vhost_vdpa_device_get_config in
vdpa-dev does not fetch the current device status from the hardware
device, causing the guest os to not receive the latest device status
information.

The hardware updates the config status of the vdpa device and then
notifies the os. The guest os receives an interrupt notification,
triggering a get_config access in the kernel, which then enters qemu
internally. Ultimately, the vhost_vdpa_device_get_config function of
vdpa-dev is called

One scenario encountered is when the device needs to bring down the
vdpa net device. After modifying the status field of virtio_net_config
in the hardware, it sends an interrupt notification. However, the guest
os always receives the STATUS field as VIRTIO_NET_S_LINK_UP.

Signed-off-by: Yuxue Liu <yuxue.liu@jaguarmicro.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20240408020003.1979-1-yuxue.liu@jaguarmicro.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Ditto, is this a -stable material (for 8.2)?

Yes it is, it has already been Cc'ed to qemu-stable. Please excuse me for
the noise.

/mjt




reply via email to

[Prev in Thread] Current Thread [Next in Thread]