Re: [PATCH v3 4/4] target/sh4: Fix mac.w with saturation enabled

[Philippe Mathieu-Daudé]

On 6/4/24 07:37, Richard Henderson wrote:
> From: Zack Buhman <zack@buhman.org>
>
> The saturation arithmetic logic in helper_macw is not correct.
> I tested and verified this behavior on a SH7091.
>
> Signed-off-by: Zack Buhman <zack@buhman.org>
> Message-Id: <20240405233802.29128-3-zack@buhman.org>
> [rth: Reformat helper_macw, add a test case.]
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/sh4/helper.h           |  2 +-
>   target/sh4/op_helper.c        | 28 +++++++++-------
>   tests/tcg/sh4/test-macw.c     | 61 +++++++++++++++++++++++++++++++++++
>   tests/tcg/sh4/Makefile.target |  3 ++
>   4 files changed, 82 insertions(+), 12 deletions(-)
>   create mode 100644 tests/tcg/sh4/test-macw.c
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>