|
| From: | Akihiko Odaki |
| Subject: | Re: [PATCH v9 16/20] virtio-net: Do not write hashes to peer buffer |
| Date: | Mon, 8 Apr 2024 10:30:51 +0900 |
| User-agent: | Mozilla Thunderbird |
On 2024/04/08 7:09, Yuri Benditovich wrote:
On Wed, Apr 3, 2024 at 2:12 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:The peer buffer is qualified with const and not meant to be modified.IMHO, this buffer is not so 'const' (although the prototype states so), it is allocated in net.c btw, another procedure in this file also modifies the buffer (work_around_broken_dhclient)
Right but it has a FIXME comment.
It also prevents enabling VIRTIO_NET_F_HASH_REPORT for peers without virtio-net header support.Does it mean _this commit_ prevents enabling VIRTIO_NET_F_HASH_REPORT for peers without virtio-net header support? Where?
No, but I meant that this patch fixes such a problem. Regards, Akihiko Odaki
| [Prev in Thread] | Current Thread | [Next in Thread] |