Re: [PATCH v6 1/2] qga: Refactor common functions between POSIX and Windows implementation

[Konstantin Kostiuk]

On Tue, Apr 2, 2024 at 12:23 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

On 29/3/24 16:31, aidan_leuck@selinc.com wrote:
> From: aidaleuc <aidan_leuck@selinc.com>
>

"In preparation of a Windows implementation, move the
  non-POSIX specific code to commands-common-ssh."

> Signed-off-by: aidaleuc <aidan_leuck@selinc.com>

As in v5
(https://lore.kernel.org/qemu-devel/63600417-9187-4d0b-8bcc-db7e965ff008@linaro.org/):

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> ---
>   qga/commands-common-ssh.c | 50 +++++++++++++++++++++++++++++++++++++++
>   qga/commands-common-ssh.h | 10 ++++++++
>   qga/commands-posix-ssh.c  | 47 +-----------------------------------
>   qga/meson.build           |  1 +
>   4 files changed, 62 insertions(+), 46 deletions(-)
>   create mode 100644 qga/commands-common-ssh.c
>   create mode 100644 qga/commands-common-ssh.h

Kostiantyn, if you take this patch, please amend the commit
description and prefix the subject with 'qga: ' :)

I will do this.

Best Regards,

Konstantin Kostiuk.

Thanks,

Phil.