qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-9.0] tests/qtest: Fix STM32L4x5 GPIO test on 32-bit


From: Cédric Le Goater
Subject: Re: [PATCH for-9.0] tests/qtest: Fix STM32L4x5 GPIO test on 32-bit
Date: Tue, 2 Apr 2024 10:26:32 +0200
User-agent: Mozilla Thunderbird

On 3/29/24 13:50, Philippe Mathieu-Daudé wrote:
Hi Cédric, Thomas,

On 29/3/24 10:27, Cédric Le Goater wrote:
The test mangles the GPIO address and the pin number in the
qtest_add_data_func data parameter. Doing so, it assumes that the host
pointer size is always 64-bit, which breaks on 32-bit :

../tests/qtest/stm32l4x5_gpio-test.c: In function ‘test_gpio_output_mode’:
../tests/qtest/stm32l4x5_gpio-test.c:272:25: error: cast from pointer to 
integer of different size [-Werror=pointer-to-int-cast]
   272 |     unsigned int pin = ((uint64_t)data) & 0xF;
       |                         ^
../tests/qtest/stm32l4x5_gpio-test.c:273:22: error: cast from pointer to 
integer of different size [-Werror=pointer-to-int-cast]
   273 |     uint32_t gpio = ((uint64_t)data) >> 32;
       |                      ^

Any clue why this isn't this covered by CI?

There is possibly an issue with cross compile in CI. I am sorry I don't
follow close enough the changes in CI to tell the exact reason. 32-bit
host support has become best effort now I suppose.

Thanks,

C.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]