[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 2/6] cxl/core: introduce cxl_mem_report_poison()
From: |
Dan Williams |
Subject: |
Re: [RFC PATCH v2 2/6] cxl/core: introduce cxl_mem_report_poison() |
Date: |
Fri, 29 Mar 2024 18:39:37 -0700 |
Shiyang Ruan wrote:
> If poison is detected(reported from cxl memdev), OS should be notified to
> handle it. So, introduce this helper function for later use:
> 1. translate DPA to HPA;
> 2. enqueue records into memory_failure's work queue;
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
This patch is too small, it needs the corresponding caller to make sense
of the proposed change.
> ---
>
> Currently poison injection from debugfs always create a 64-bytes-length
> record, which is fine. But the injection from qemu's QMP API:
> qmp_cxl_inject_poison() could create a poison record contains big length,
> which may cause many many times of calling memory_failure_queue().
> Though the MEMORY_FAILURE_FIFO_SIZE is 1 << 4, it seems not enougth.
What matters is what devices do in practice, the kernel should not be
worried about odd corner cases that only exist in QEMU injection
scenarios.
- [RFC PATCH v2 0/6] cxl: add poison event handler, Shiyang Ruan, 2024/03/29
- [RFC PATCH v2 2/6] cxl/core: introduce cxl_mem_report_poison(), Shiyang Ruan, 2024/03/29
- Re: [RFC PATCH v2 2/6] cxl/core: introduce cxl_mem_report_poison(),
Dan Williams <=
- [RFC PATCH v2 4/6] cxl/core: report poison when injecting from debugfs, Shiyang Ruan, 2024/03/29
- [RFC PATCH v2 3/6] cxl/core: add report option for cxl_mem_get_poison(), Shiyang Ruan, 2024/03/29
- [RFC PATCH v2 1/6] cxl/core: correct length of DPA field masks, Shiyang Ruan, 2024/03/29
- [RFC PATCH v2 5/6] cxl: add definition for transaction types, Shiyang Ruan, 2024/03/29
- [RFC PATCH v2 6/6] cxl/core: add poison injection event handler, Shiyang Ruan, 2024/03/29