RE: [PATCH v2 1/9] Hexagon (target/hexagon) Add is_old/is_new to Register class

[Brian Cain]

> -----Original Message-----
> From: Taylor Simpson <ltaylorsimpson@gmail.com>
> Sent: Wednesday, March 6, 2024 9:23 PM
> To: qemu-devel@nongnu.org
> Cc: Brian Cain <bcain@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathbern@quicinc.com>; Sid Manning <sidneym@quicinc.com>;
> Marco Liebel (QUIC) <quic_mliebel@quicinc.com>;
> richard.henderson@linaro.org; philmd@linaro.org; ale@rev.ng; anjo@rev.ng;
> ltaylorsimpson@gmail.com
> Subject: [PATCH v2 1/9] Hexagon (target/hexagon) Add is_old/is_new to
> Register class
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
> 
> Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---

Reviewed-by: Brian Cain <bcain@quicinc.com>

>  target/hexagon/hex_common.py | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/target/hexagon/hex_common.py
> b/target/hexagon/hex_common.py
> index 195620c7ec..4bacef223f 100755
> --- a/target/hexagon/hex_common.py
> +++ b/target/hexagon/hex_common.py
> @@ -1,7 +1,7 @@
>  #!/usr/bin/env python3
> 
>  ##
> -##  Copyright(c) 2019-2023 Qualcomm Innovation Center, Inc. All Rights
> Reserved.
> +##  Copyright(c) 2019-2024 Qualcomm Innovation Center, Inc. All Rights
> Reserved.
>  ##
>  ##  This program is free software; you can redistribute it and/or modify
>  ##  it under the terms of the GNU General Public License as published by
> @@ -397,10 +397,18 @@ def is_readwrite(self):
>  class OldSource(Source):
>      def reg_tcg(self):
>          return f"{self.regtype}{self.regid}V"
> +    def is_old(self):
> +        return True
> +    def is_new(self):
> +        return False
> 
>  class NewSource(Source):
>      def reg_tcg(self):
>          return f"{self.regtype}{self.regid}N"
> +    def is_old(self):
> +        return False
> +    def is_new(self):
> +        return True
> 
>  class ReadWrite:
>      def reg_tcg(self):
> @@ -413,6 +421,10 @@ def is_read(self):
>          return True
>      def is_readwrite(self):
>          return True
> +    def is_old(self):
> +        return True
> +    def is_new(self):
> +        return False
> 
>  class GprDest(Register, Single, Dest):
>      def decl_tcg(self, f, tag, regno):
> --
> 2.34.1