Re: [PATCH v5 1/2] Refactor common functions between POSIX and Windows implementation

[Philippe Mathieu-Daudé]

On 28/3/24 16:40, aidan_leuck@selinc.com wrote:
> From: aidaleuc <aidan_leuck@selinc.com>
>
> Signed-off-by: aidaleuc <aidan_leuck@selinc.com>
> ---
>   qga/commands-common-ssh.c | 50 ++++++++++++++++++++++++++++++++++++++
>   qga/commands-common-ssh.h | 10 ++++++++
>   qga/commands-posix-ssh.c  | 51 +++------------------------------------
>   qga/meson.build           |  1 +
>   4 files changed, 64 insertions(+), 48 deletions(-)
>   create mode 100644 qga/commands-common-ssh.c
>   create mode 100644 qga/commands-common-ssh.h


> diff --git a/qga/commands-posix-ssh.c b/qga/commands-posix-ssh.c
> index 236f80de44..c82ccfe629 100644
> --- a/qga/commands-posix-ssh.c
> +++ b/qga/commands-posix-ssh.c
> @@ -9,12 +9,13 @@
>   #include <locale.h>
>   #include <pwd.h>
>   
> +#include "commands-common-ssh.h"
>   #include "qapi/error.h"
>   #include "qga-qapi-commands.h"
>   
>   #ifdef QGA_BUILD_UNIT_TEST
> -static struct passwd *
> -test_get_passwd_entry(const gchar *user_name, GError **error)
> + static struct passwd *
> + test_get_passwd_entry(const gchar *user_name, GError **error)

Modulo this spurious change,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thank you for your various iterations,

Phil.