[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 17/19] hw/nvme: fix -Werror=maybe-uninitialized
From: |
marcandre . lureau |
Subject: |
[PATCH 17/19] hw/nvme: fix -Werror=maybe-uninitialized |
Date: |
Thu, 28 Mar 2024 14:20:50 +0400 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
../hw/nvme/ctrl.c:6081:21: error: ‘result’ may be used uninitialized
[-Werror=maybe-uninitialized]
It's not obvious that 'result' is set in all code paths. When &result is
a returned argument, it's even less clear.
Looking at various assignments, 0 seems to be a suitable default value.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/nvme/ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index c2b17de987..127c3d2383 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -5894,7 +5894,7 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeRequest
*req)
uint32_t dw10 = le32_to_cpu(cmd->cdw10);
uint32_t dw11 = le32_to_cpu(cmd->cdw11);
uint32_t nsid = le32_to_cpu(cmd->nsid);
- uint32_t result;
+ uint32_t result = 0;
uint8_t fid = NVME_GETSETFEAT_FID(dw10);
NvmeGetFeatureSelect sel = NVME_GETFEAT_SELECT(dw10);
uint16_t iv;
--
2.44.0
- Re: [PATCH 11/19] migration/block: fix -Werror=maybe-uninitialized false-positive, (continued)
- [PATCH 12/19] migration: fix -Werror=maybe-uninitialized false-positives, marcandre . lureau, 2024/03/28
- [PATCH 13/19] hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/03/28
- [PATCH 14/19] plugins: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/03/28
- [PATCH 15/19] migration: fix -Werror=maybe-uninitialized false-positive, marcandre . lureau, 2024/03/28
- [PATCH 16/19] tests: fix -Werror=maybe-uninitialized, marcandre . lureau, 2024/03/28
- [PATCH 17/19] hw/nvme: fix -Werror=maybe-uninitialized,
marcandre . lureau <=
- [PATCH 18/19] hw/virtio: fix -Werror=maybe-uninitialized, marcandre . lureau, 2024/03/28
- [PATCH 19/19] RFC: hw/virtio: a potential leak fix, marcandre . lureau, 2024/03/28
- Re: [PATCH 00/19] -Werror=maybe-uninitialized fixes, Eric Blake, 2024/03/28