qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1


From: Zhao Liu
Subject: Re: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1
Date: Thu, 28 Mar 2024 18:21:26 +0800

Hi Paolo,

Just meet typos when compiling ;-)

On Mon, Mar 25, 2024 at 03:14:20PM +0100, Paolo Bonzini wrote:
> Date: Mon, 25 Mar 2024 15:14:20 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1
> X-Mailer: git-send-email 2.44.0

[snip]

> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index b1dcb3857f0..67e8b0b05e8 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -859,14 +859,26 @@ bool css_migration_enabled(void)
>      }                                                                        
>  \
>      type_init(ccw_machine_register_##suffix)
>  
> +static void ccw_machine_9_1_instance_options(MachineState *machine)
> +{
> +}
> +
> +static void ccw_machine_9_1_class_options(MachineClass *mc)
> +{
> +}
> +DEFINE_CCW_MACHINE(9_0, "9.1", true);

Should be:

DEFINE_CCW_MACHINE(9_1, "9.1", true);

> +
>  static void ccw_machine_9_0_instance_options(MachineState *machine)
>  {
> +    ccw_machine_9_1_instance_options(machine);
>  }
>  
>  static void ccw_machine_9_0_class_options(MachineClass *mc)
>  {
> +    ccw_machine_9_1_class_options(machine);

s/machine/mc/

Regards,
Zhao




reply via email to

[Prev in Thread] Current Thread [Next in Thread]