Re: [RFC] util/error-report: Add "error: " prefix for error-level report

[Zhao Liu]

On Wed, Mar 27, 2024 at 01:36:07PM +0100, Thomas Huth wrote:

[snip]

> Sounds like a good idea to me, but I think you should then also remove
> the hard-coded "error:" strings in the various error_reports():

Thanks Thomas! I missed this case, will remove these hard-code prefix
first.

> $ grep -ri 'error_report.*"error:'
> migration/block-dirty-bitmap.c:        error_report("Error: block device name 
> is not set");
> migration/block-dirty-bitmap.c:                error_report("Error: Unknown 
> bitmap alias '%s' on node "
> migration/block-dirty-bitmap.c:                error_report("Error: unknown 
> dirty bitmap "
> migration/block-dirty-bitmap.c:        error_report("Error: block device name 
> is not set");
> target/i386/kvm/kvm.c:        error_report("error: failed to set MSR 0x%" 
> PRIx32 " to 0x%" PRIx64,
> target/i386/kvm/kvm.c:        error_report("error: failed to get MSR 0x%" 
> PRIx32,
> util/vhost-user-server.c:        error_report("Error: too big message 
> request: %d, "
> accel/hvf/hvf-all.c:        error_report("Error: HV_ERROR");
> accel/hvf/hvf-all.c:        error_report("Error: HV_BUSY");
> accel/hvf/hvf-all.c:        error_report("Error: HV_BAD_ARGUMENT");
> accel/hvf/hvf-all.c:        error_report("Error: HV_NO_RESOURCES");
> accel/hvf/hvf-all.c:        error_report("Error: HV_NO_DEVICE");
> accel/hvf/hvf-all.c:        error_report("Error: HV_UNSUPPORTED");
> accel/hvf/hvf-all.c:        error_report("Error: HV_DENIED");
> monitor/hmp-cmds.c:        error_reportf_err(err, "Error: ");
> hw/arm/xlnx-zcu102.c:        error_report("ERROR: RAM size 0x%" PRIx64 " 
> above max supported of "
> hw/block/dataplane/xen-block.c:        error_report("error: unknown operation 
> (%d)", request->req.operation);
> hw/block/dataplane/xen-block.c:        error_report("error: write req for ro 
> device");
> hw/block/dataplane/xen-block.c:            error_report("error: nr_segments 
> too big");
> hw/block/dataplane/xen-block.c:            error_report("error: first > last 
> sector");
> hw/block/dataplane/xen-block.c:            error_report("error: page 
> crossing");
> hw/block/dataplane/xen-block.c:        error_report("error: access beyond end 
> of file");
> hw/rdma/rdma_backend.c:            rdma_error_report("Error: Not a MAD 
> request, skipping");
> hw/s390x/s390-skeys.c:        error_report("Error: Setting storage keys for 
> pages with unallocated "
> hw/s390x/s390-skeys.c:        error_report("Error: Getting storage keys for 
> pages with unallocated "
> hw/usb/bus.c:        error_report("Error: no usb bus to attach usbdevice %s, "
> gdbstub/gdbstub.c:            error_report("Error: Bad gdb register numbering 
> for '%s', "
> 
>  Thomas
> 
>