Re: [PATCH-for-9.1 01/18] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine

[Philippe Mathieu-Daudé]

On 6/3/24 17:41, Thomas Huth wrote:
> On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
> > The pc-i440fx-2.0 machine was deprecated for the 8.2
> > release (see commit c7437f0ddb "docs/about: Mark the
> > old pc-i440fx-2.0 - 2.3 machine types as deprecated"),
> > time to remove it.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   docs/about/deprecated.rst       |  2 +-
> >   docs/about/removed-features.rst |  2 +-
> >   include/hw/i386/pc.h            |  3 ---
> >   hw/i386/pc.c                    | 15 -------------
> >   hw/i386/pc_piix.c               | 37 ---------------------------------
> >   5 files changed, 2 insertions(+), 57 deletions(-)


> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index f5ff970acf..bb7ef31af2 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -311,21 +311,6 @@ GlobalProperty pc_compat_2_1[] = {
> >   };
> >   const size_t pc_compat_2_1_len = G_N_ELEMENTS(pc_compat_2_1);
> > -GlobalProperty pc_compat_2_0[] = {
> > -    PC_CPU_MODEL_IDS("2.0.0")
> > -    { "virtio-scsi-pci", "any_layout", "off" },
> > -    { "PIIX4_PM", "memory-hotplug-support", "off" },
> > -    { "apic", "version", "0x11" },
> > -    { "nec-usb-xhci", "superspeed-ports-first", "off" },
> > -    { "nec-usb-xhci", "force-pcie-endcap", "on" },
> > -    { "pci-serial", "prog_if", "0" },
> > -    { "pci-serial-2x", "prog_if", "0" },
> > -    { "pci-serial-4x", "prog_if", "0" },
> > -    { "virtio-net-pci", "guest_announce", "off" },
> > -    { "ICH9-LPC", "memory-hotplug-support", "off" },
>
> I think you could clean up memory-hotplug-support for the ICH9-LPC 
> device now, too (in a separate patch).

Great suggestion, thanks!

> For this patch here:
> Reviewed-by: Thomas Huth <thuth@redhat.com>